Skip to content

return only 1 row per active installer - #41300

Merged
jahzielv merged 7 commits into
mainfrom
41277-pagination
Mar 10, 2026
Merged

return only 1 row per active installer#41300
jahzielv merged 7 commits into
mainfrom
41277-pagination

Conversation

@jahzielv

@jahzielv jahzielv commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Related issue: Resolves #41277

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects

Testing

For unreleased bug fixes in a release candidate, one of:

  • Confirmed that the fix is not expected to adversely impact load test results

@codecov

codecov Bot commented Mar 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.35%. Comparing base (6fb0d75) to head (2feff34).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #41300      +/-   ##
==========================================
+ Coverage   66.34%   66.35%   +0.01%     
==========================================
  Files        2477     2477              
  Lines      198395   198493      +98     
  Branches     8891     8889       -2     
==========================================
+ Hits       131619   131719     +100     
+ Misses      54874    54867       -7     
- Partials    11902    11907       +5     
Flag Coverage Δ
backend 68.14% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jahzielv
jahzielv marked this pull request as ready for review March 10, 2026 01:47
@jahzielv
jahzielv requested a review from a team as a code owner March 10, 2026 01:47

@cdcme cdcme left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests!

@jahzielv
jahzielv merged commit 086f815 into main Mar 10, 2026
48 checks passed
@jahzielv
jahzielv deleted the 41277-pagination branch March 10, 2026 13:13
jahzielv added a commit that referenced this pull request Mar 10, 2026
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #41277 

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [x] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements), JS
inline code is prevented especially for url redirects

## Testing

- [x] Added/updated automated tests
- [x] Where appropriate, [automated tests simulate multiple hosts and
test for host
isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing)
(updates to one hosts's records do not affect another)

- [x] QA'd all new/changed functionality manually

For unreleased bug fixes in a release candidate, one of:

- [x] Confirmed that the fix is not expected to adversely impact load
test results
jahzielv added a commit that referenced this pull request Mar 10, 2026
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #41277 

cherry-pick for #41300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Host software pagination returns short/overlapping pages when a title has multiple installers

2 participants