Skip to content

return only 1 row per active installer (#41300) - #41330

Merged
jahzielv merged 1 commit into
rc-minor-fleet-v4.82.0from
cherry-pick-41277-pagination
Mar 10, 2026
Merged

return only 1 row per active installer (#41300)#41330
jahzielv merged 1 commit into
rc-minor-fleet-v4.82.0from
cherry-pick-41277-pagination

Conversation

@jahzielv

Copy link
Copy Markdown
Contributor

Related issue: Resolves #41277

cherry-pick for #41300

<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #41277 

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [x] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements), JS
inline code is prevented especially for url redirects

## Testing

- [x] Added/updated automated tests
- [x] Where appropriate, [automated tests simulate multiple hosts and
test for host
isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing)
(updates to one hosts's records do not affect another)

- [x] QA'd all new/changed functionality manually

For unreleased bug fixes in a release candidate, one of:

- [x] Confirmed that the fix is not expected to adversely impact load
test results
@jahzielv
jahzielv requested a review from a team as a code owner March 10, 2026 14:01
@codecov

codecov Bot commented Mar 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (rc-minor-fleet-v4.82.0@1e6735c). Learn more about missing BASE report.

Additional details and impacted files
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.82.0   #41330   +/-   ##
=========================================================
  Coverage                          ?   66.13%           
=========================================================
  Files                             ?     1440           
  Lines                             ?   163283           
  Branches                          ?        0           
=========================================================
  Hits                              ?   107984           
  Misses                            ?    44363           
  Partials                          ?    10936           
Flag Coverage Δ
backend 66.13% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jahzielv

Copy link
Copy Markdown
Contributor Author

test failures are unrelated

@jahzielv
jahzielv merged commit 86981c2 into rc-minor-fleet-v4.82.0 Mar 10, 2026
41 of 44 checks passed
@jahzielv
jahzielv deleted the cherry-pick-41277-pagination branch March 10, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Host software pagination returns short/overlapping pages when a title has multiple installers

2 participants