fix(software): paginate host software pages by distinct title IDs - #41351
Closed
SergioChan wants to merge 1 commit into
Closed
fix(software): paginate host software pages by distinct title IDs#41351SergioChan wants to merge 1 commit into
SergioChan wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #41351 +/- ##
==========================================
- Coverage 66.36% 65.98% -0.39%
==========================================
Files 2477 2477
Lines 198496 198527 +31
Branches 8891 8891
==========================================
- Hits 131729 130995 -734
- Misses 54865 55624 +759
- Partials 11902 11908 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Already fixed in #41300. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves #41277
Summary
ListHostSoftwareusing a distinct title-id query first, then fetch/hydrate rows only for that page of title IDsORDER BY FIELD(id, ...)when loading detailed rows for dedup/hydrationtestListHostSoftwarePaginationWithMultipleInstallersto verify page 1 contains a full page with no overlap against page 0Testing
Validation run in this environment:
go test ./server/datastore/mysql -run TestDatastoreReplica -count=1Note: the
ListHostSoftwarePaginationWithMultipleInstallersintegration-style datastore test was updated but not executable in this runtime because the required datastore integration harness (seeded MySQL test setup) is not active in this isolated run.