gkarr cp 81.1 fixes - #40891
Merged
Merged
Conversation
georgekarrv
commented
Mar 3, 2026
georgekarrv
commented
Member
- Batch select query in CleanupExcessQueryResultRows (Batch select query in CleanupExcessQueryResultRows #40491)
- Cherry-pick: Remove "do not enqueue setup experience items >24 hours after enrollment" logic for macOS hosts (Remove "do not enqueue setup experience items >24 hours after enrollment" logic for macOS hosts #40739) (Cherry-pick: Remove "do not enqueue setup experience items >24 hours after enrollment" logic for macOS hosts (#40739) #40748)
<!-- Add the related story/sub-task/bug number, like Resolves #123, or remove if NA --> **Related issue:** Resolves #40476 # Checklist for submitter - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. ## Testing - [x] Added/updated automated tests - [x] QA'd all new/changed functionality manually Before: - inserted 70k queries to my local DB, saw the cron failing: <img width="864" height="120" alt="Screenshot 2026-02-25 at 12 54 31 PM" src="https://github.com/user-attachments/assets/d1e19aa8-56aa-46a2-a437-7ae5da1e5b1e" /> - ran new test without code fix, it failed with the same error in the issue: <img width="920" height="324" alt="Screenshot 2026-02-25 at 12 45 41 PM" src="https://github.com/user-attachments/assets/c7342d81-f223-449e-a861-c7bae58bbe9e" /> After: ran test again, it passed <img width="1556" height="174" alt="Screenshot 2026-02-25 at 12 45 04 PM" src="https://github.com/user-attachments/assets/9eed3e6e-3ce6-4d69-aa70-9ebcfcf07623" />
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rc-minor-fleet-v4.82.0 #40891 +/- ##
=========================================================
Coverage ? 66.09%
=========================================================
Files ? 1440
Lines ? 163251
Branches ? 0
=========================================================
Hits ? 107908
Misses ? 44403
Partials ? 10940
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cdcme
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.