Batch select query in CleanupExcessQueryResultRows

[nulmete]

Related issue: Resolves #40476

Checklist for submitter

• Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
  See Changes files for more information.

Testing

• Added/updated automated tests

• QA'd all new/changed functionality manually

Before:

• inserted 70k queries to my local DB, saw the cron failing:

INSERT INTO queries (name, description, query, author_id, logging_type, discard_data, saved)
  SELECT
    CONCAT('bulk_query_', seq),
    '',
    'SELECT 1',
    (SELECT id FROM users LIMIT 1),
    'snapshot',
    false,
    1
  FROM (
    SELECT a.N + b.N*10 + c.N*100 + d.N*1000 + e.N*10000 as seq
    FROM
      (SELECT 0 AS N UNION SELECT 1 UNION SELECT 2 UNION SELECT 3 UNION SELECT 4 UNION SELECT 5 UNION SELECT 6
  UNION SELECT 7 UNION SELECT 8 UNION SELECT 9) a,
      (SELECT 0 AS N UNION SELECT 1 UNION SELECT 2 UNION SELECT 3 UNION SELECT 4 UNION SELECT 5 UNION SELECT 6
  UNION SELECT 7 UNION SELECT 8 UNION SELECT 9) b,
      (SELECT 0 AS N UNION SELECT 1 UNION SELECT 2 UNION SELECT 3 UNION SELECT 4 UNION SELECT 5 UNION SELECT 6
  UNION SELECT 7 UNION SELECT 8 UNION SELECT 9) c,
      (SELECT 0 AS N UNION SELECT 1 UNION SELECT 2 UNION SELECT 3 UNION SELECT 4 UNION SELECT 5 UNION SELECT 6
  UNION SELECT 7 UNION SELECT 8 UNION SELECT 9) d,
      (SELECT 0 AS N UNION SELECT 1 UNION SELECT 2 UNION SELECT 3 UNION SELECT 4 UNION SELECT 5 UNION SELECT 6
  UNION SELECT 7 UNION SELECT 8 UNION SELECT 9) e
  ) numbers
  WHERE seq < 70000;

• ran new test without code fix, it failed with the same error in the issue:

After: ran test again, it passed

[codecov]

Codecov Report

❌ Patch coverage is 55.55556% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.27%. Comparing base (a3166c4) to head (9b0db93).
⚠️ Report is 30 commits behind head on main.

Files with missing lines	Patch %	Lines
server/datastore/mysql/query_results.go	55.55%	4 Missing and 4 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #40491   +/-   ##
=======================================
  Coverage   66.26%   66.27%           
=======================================
  Files        2461     2461           
  Lines      197427   197434    +7     
  Branches     8655     8655           
=======================================
+ Hits       130832   130847   +15     
+ Misses      54749    54745    -4     
+ Partials    11846    11842    -4     

Flag	Coverage Δ
backend	68.14% <55.55%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sgress454]

This looks good but I think the bigger fix is to update the SQL for the initial QueryIDs statement here to include saved=1 in the WHERE clause. Live reports don't save rows in the query_results table anyway so there's nothing to clean up for them, and we're wasting cycles fetching them.

Your added batching is still a good idea, just in case a customer really does have >65k saved reports, but it should rarely be used if we fix the filtering.