Skip to content

Remove "do not enqueue setup experience items >24 hours after enrollment" logic for macOS hosts - #40739

Merged
gillespi314 merged 2 commits into
mainfrom
JM-40725
Feb 27, 2026
Merged

Remove "do not enqueue setup experience items >24 hours after enrollment" logic for macOS hosts#40739
gillespi314 merged 2 commits into
mainfrom
JM-40725

Conversation

@JordanMontgomery

@JordanMontgomery JordanMontgomery commented Feb 27, 2026

Copy link
Copy Markdown
Member

Related issue: Resolves #40725

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)

  • If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes

Testing

@JordanMontgomery JordanMontgomery changed the title Add changes file Remove "do not enqueue setup experience items >24 hours after enrollment" logic for macOS hosts Feb 27, 2026
@gillespi314
gillespi314 merged commit d4237f8 into main Feb 27, 2026
38 checks passed
@gillespi314
gillespi314 deleted the JM-40725 branch February 27, 2026 22:15
@codecov

codecov Bot commented Feb 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.30%. Comparing base (57c4f8c) to head (1a55057).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
server/datastore/mysql/setup_experience.go 88.23% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #40739   +/-   ##
=======================================
  Coverage   66.30%   66.30%           
=======================================
  Files        2468     2468           
  Lines      197491   197492    +1     
  Branches     8772     8772           
=======================================
+ Hits       130939   130945    +6     
+ Misses      54708    54704    -4     
+ Partials    11844    11843    -1     
Flag Coverage Δ
backend 68.10% <88.23%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gillespi314 pushed a commit that referenced this pull request Feb 27, 2026
JordanMontgomery added a commit that referenced this pull request Feb 28, 2026
…after enrollment" logic for macOS hosts (#40739) (#40748)

Cherry-pick #40739

Co-authored-by: Jordan Montgomery <elijah.jordan.montgomery@gmail.com>
georgekarrv pushed a commit that referenced this pull request Mar 3, 2026
…after enrollment" logic for macOS hosts (#40739) (#40748)

Cherry-pick #40739

Co-authored-by: Jordan Montgomery <elijah.jordan.montgomery@gmail.com>
This was referenced Mar 3, 2026
@georgekarrv georgekarrv mentioned this pull request Mar 6, 2026
georgekarrv added a commit that referenced this pull request Mar 10, 2026
- **Batch select query in CleanupExcessQueryResultRows (#40491)**
- **Cherry-pick: Remove "do not enqueue setup experience items >24 hours
after enrollment" logic for macOS hosts (#40739) (#40748)**

---------

Co-authored-by: Nico <32375741+nulmete@users.noreply.github.com>
Co-authored-by: Sarah Gillespie <73313222+gillespi314@users.noreply.github.com>
Co-authored-by: Jordan Montgomery <elijah.jordan.montgomery@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setup experience not running during DEP enrollment for existing host.

2 participants