Conversation
cafkafk
changed the title
|
I've looked into this and I am all for it. I would definitely consider it a breaking change so as always: There will be setups broken. I was confused earlier because ogham/exa#1094 showed up as the Gentoo logo in my terminal. |
|
I'd just say we should decide on either blocking this by all other icon changes or vice versa because they have obvious overlap. |
I don't use icons at all, so I'll deffer to your judgment on this. I think we should mark all issues dealing with icons with a label first and then assess the whole situation, right now I don't really have an overview. Also, if we are lucky and the contributor that made the PR shows up I'd love to hear what they think about it. |
|
Ok, in that case: Let's block this one. It's easier to change/review one big one than every other small icon change in this case. Marking all the icon-related ones sounds smart. 👍 |
|
This is affected by #28 |
cafkafk
added
features › icon
features › ui
and removed
help wanted
|
I'm gonna try to have a crack at this but it's probably easier as a new pr, the merge would annoying. I'll add @Zer0-x as co-author on the commits. |
| "Justfile", "Procfile", "Dockerfile", "Containerfile", "Vagrantfile", "Brewfile", | ||
| "Gemfile", "Pipfile", "build.sbt", "mix.exs", "bsconfig.json", "tsconfig.json", | ||
| "Justfile", "justfile", "Procfile", "Dockerfile", "Containerfile", "Vagrantfile", | ||
| "Brewfile", "Gemfile", "Pipfile", "build.sbt", "mix.exs", "bsconfig.json", "tsconfig.json", |
| "png", "jfi", "jfif", "jif", "jpe", "jpeg", "jpg", "gif", "bmp", "tiff", | ||
| "tif", "ppm", "pgm", "pbm", "pnm", "webp", "raw", "arw", "svg", "stl", "eps", | ||
| "dvi", "ps", "cbr", "jpf", "cbz", "xpm", "ico", "cr2", "orf", "nef", | ||
| "heif", "avif", "jxl", "j2k", "jp2", "j2c", "jpx", "pxm", |
There was a problem hiding this comment.
pxm is the only addition here
| file.extension_is_one_of( &[ | ||
| "avi", "flv", "m2v", "m4v", "mkv", "mov", "mp4", "mpeg", | ||
| "mpg", "ogm", "ogv", "vob", "wmv", "webm", "m2ts", "heic", | ||
| "mpg", "ogm", "ogv", "vob", "wmv", "webm", "m2ts", "heic", "video", |
There was a problem hiding this comment.
I've never seen this video format before, need example
| "zip", "tar", "Z", "z", "gz", "bz2", "a", "ar", "7z", | ||
| "iso", "dmg", "tc", "rar", "par", "tgz", "xz", "txz", | ||
| "lz", "tlz", "lzma", "deb", "rpm", "zst", "lz4", "cpio", | ||
| "zip", "tar", "taz", "Z", "z", "gz", "bz", "bz2", "a", "ar", |
| "zip", "tar", "taz", "Z", "z", "gz", "bz", "bz2", "a", "ar", | ||
| "7z", "iso", "dmg", "tc", "rar", "par", "tgz", "xz", "txz", | ||
| "lz", "tlz", "lzma", "deb", "rpm", "zst", "lz4", "cpio", "lzh", | ||
| "lzo", "tbz", "tbz2", "tz", "tzo" |
There was a problem hiding this comment.
"lzh",
"lzo", "tbz", "tbz2", "tz", "tzo"
all seem new
| else if self.is_compressed(file) { | ||
| Some(Icons::Compressed.value()) | ||
| } |
| Self::Audio => '\u{f001}', | ||
| Self::Image => '\u{f1c5}', | ||
| Self::Video => '\u{f03d}', | ||
| Self::Audio => '\u{f001}', // |
| Self::Audio => '\u{f001}', // | ||
| Self::Image => '\u{f1c5}', // | ||
| Self::Video => '\u{f03d}', // | ||
| Self::Compressed => '\u{f410}', // |
| let mut m = HashMap::new(); | ||
| m.insert(".Trash", '\u{f1f8}'); // | ||
| // Icon for specific file name | ||
| m.insert(".atom", '\u{e764}'); // | ||
| m.insert(".bashprofile", '\u{e615}'); // | ||
| m.insert(".bashrc", '\u{f489}'); // | ||
| m.insert(".git", '\u{f1d3}'); // | ||
| m.insert(".gitattributes", '\u{f1d3}'); // | ||
| m.insert(".gitconfig", '\u{f1d3}'); // | ||
| m.insert(".github", '\u{f408}'); // | ||
| m.insert(".gitignore", '\u{f1d3}'); // | ||
| m.insert(".gitmodules", '\u{f1d3}'); // | ||
| m.insert("gitignore_global", '\u{f1d3}'); // | ||
| m.insert(".rvm", '\u{e21e}'); // | ||
| m.insert(".vimrc", '\u{e62b}'); // | ||
| m.insert(".vscode", '\u{e70c}'); // | ||
| m.insert(".zshrc", '\u{f489}'); // | ||
| m.insert("Cargo.lock", '\u{e7a8}'); // | ||
| m.insert("bin", '\u{e5fc}'); // | ||
| m.insert("config", '\u{e5fc}'); // | ||
| m.insert("Cargo.lock", '\u{f1617}'); // | ||
| m.insert("docker-compose.yml", '\u{f308}'); // | ||
| m.insert("Dockerfile", '\u{f308}'); // | ||
| m.insert("ds_store", '\u{f179}'); // | ||
| m.insert("gitignore_global", '\u{f1d3}'); // | ||
| m.insert("go.mod", '\u{e626}'); // | ||
| m.insert("go.sum", '\u{e626}'); // | ||
| m.insert("gradle", '\u{e256}'); // |
There was a problem hiding this comment.
all from this point should be a separate PR imo
3 participants
ogham/exa#1196