Skip to content

(exa PR) 1119#36

Closed
cafkafk wants to merge 2 commits into
mainfrom
pr-1119
Closed

(exa PR) 1119#36
cafkafk wants to merge 2 commits into
mainfrom
pr-1119

Conversation

@cafkafk

@cafkafk cafkafk commented Jul 29, 2023

Copy link
Copy Markdown
Member

github.com/ogham/exa/pulls/1119

Trash  # ~/.local/share/Trash
*.a  # ~/.pyenv/versions/3.9.13/lib/libpython3.9.a
*.mdb  # https://github.com/NVIDIA/DALI_extra/tree/main/db/lmdb
xinitrc  # /etc/X11/xinit/xinitrc
xserverrc  # /etc/X11/xinit/xserverrc
*.bash_logout  # /etc/bash.bash_logout
.xinitrc  # ~/.xinitrc
.xprofile  # ~/.xprofile
.pam_environment  # ~/.pam_environment
requirements.txt  # python config file

@cafkafk cafkafk left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about these

Comment thread src/output/icons.rs
m.insert(".xprofile", '\u{f489}'); // 
m.insert(".zshrc", '\u{f489}'); // 
m.insert("Cargo.lock", '\u{e7a8}'); //
m.insert("AUTHORS", '\u{f718}'); //

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This symbol doesn't render for me

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they should render on the nerdfonts site: https://www.nerdfonts.com/cheat-sheet

I found it under 'document'
New name seems to be 'nf-md-file_document' (will be fixed with #9)

Comment thread src/output/icons.rs
Comment on lines +65 to +66
m.insert(".xinitrc", '\u{f489}'); // 
m.insert(".xprofile", '\u{f489}'); // 

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about these

Comment thread src/output/icons.rs
m.insert("Cargo.lock", '\u{e7a8}'); //
m.insert("AUTHORS", '\u{f718}'); //
m.insert("bin", '\u{e5fc}'); // 
m.insert("Cargo.lock", '\u{e7a8}'); // 

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems to be already present on main (at least it shows that icon when I run with --icons)

Comment thread src/output/icons.rs
m.insert("hidden", '\u{f023}'); // 
m.insert("include", '\u{e5fc}'); // 
m.insert("lib", '\u{f121}'); // 
m.insert("LICENSE", '\u{f718}'); // 

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This symbol doesn't render for me

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same document icon 'nf-md-file_document'

Comment thread src/output/icons.rs
else if let Some(icon) = extensions.icon_file(file) { icon }
else if let Some(ext) = file.ext.as_ref() {
match ext.as_str() {
"a" => '\u{f17c}', // 

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure what this even is

Comment thread src/output/icons.rs
"awk" => '\u{f489}', // 
"bash" => '\u{f489}', // 
"bash_history" => '\u{f489}', // 
"bash_logout" => '\u{f489}', // 

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is optimal

@sbatial sbatial mentioned this pull request Jul 30, 2023
63 tasks
@sbatial

sbatial commented Jul 30, 2023

Copy link
Copy Markdown
Collaborator

I think it would make sense to maybe close this one and apply the proposed changes after #9
Because as far as I can tell #9 is as good as ready now.

I would then go forward with reviewing it

@cafkafk cafkafk closed this Jul 30, 2023
@cafkafk cafkafk deleted the pr-1119 branch July 30, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants