Skip to content

(exa PR) 1094#40

Merged
sbatial merged 3 commits into
mainfrom
pr-1094
Jul 30, 2023
Merged

(exa PR) 1094#40
sbatial merged 3 commits into
mainfrom
pr-1094

Conversation

@cafkafk

@cafkafk cafkafk commented Jul 29, 2023

Copy link
Copy Markdown
Member

github.com/ogham/exa/pulls/1094

sbatial
sbatial approved these changes Jul 30, 2023
View reviewed changes

@sbatial sbatial left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: needs to be fixed to work with newer nerdfonts I think (but that's what #9 is for)

@cafkafk

cafkafk commented Jul 30, 2023

Copy link
Copy Markdown
Member Author

note: needs to be fixed to work with newer nerdfonts I think (but that's what #9 is for)

I'll make it a draft until that's done.

@cafkafk cafkafk marked this pull request as draft July 30, 2023 03:21
@sbatial

sbatial commented Jul 30, 2023

Copy link
Copy Markdown
Collaborator

Ah no. I formulated it wrong.
It'll can be merged for now and then changed in bulk with all the others in #9

@sbatial sbatial marked this pull request as ready for review July 30, 2023 11:50
@sbatial sbatial merged commit bd699bd into main Jul 30, 2023
@sbatial sbatial deleted the pr-1094 branch July 30, 2023 11:50
@sbatial sbatial mentioned this pull request Jul 30, 2023
Closed
63 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbatial sbatial sbatial approved these changes

Assignees

No one assigned

Labels

features › icon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cafkafk @sbatial @mihaigalos