Conversation
7 tasks
spencer-tb
force-pushed
the
eips/amsterdam/eip-8282-review-feedback
branch
from
July 2, 2026 18:20
35468b0 to
9e16e43
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## eips/amsterdam/eip-8282 #3090 +/- ##
============================================================
+ Coverage 53.48% 93.24% +39.76%
============================================================
Files 624 624
Lines 36936 36951 +15
Branches 3375 3379 +4
============================================================
+ Hits 19754 34454 +14700
+ Misses 16828 1704 -15124
- Partials 354 793 +439
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
marioevz
added a commit
that referenced
this pull request
Jul 2, 2026
* feat(spec,tests): Implement EIP-8282 (#2990) * feat(specs): Implement EIP-8282 * feat(test-forks): Implement EIP-8282 framework changes * feat(tests): Implement EIP-8282 tests * feat(tests): Add EIP-8282 to EIP-7685 tests * fix(test-forks): Update EIP-8282 deposit contract to 537b9c1 * fix(tests): Update EIP-8282 builder deposit contract target/max to 32/256 * fix(tests): Failing tests after update * refactor(test-forks): Introduce `minimum_block_gas_limit` * refactor(test-forks): Update EIP-8282 `empty_block_bal_item_count` * refactor(test-forks): Use pkgutil to load contract binaries * refactor(test-forks): Use pkgutil to load EIP-8282 contract binaries * refactor(test-forks): Remove pre_allocation_blockchain type: ignore comments * refactor(test-forks): Remove EIP-8282 pre_allocation_blockchain type: ignore comments * Update tests/amsterdam/eip8282_builder_execution_requests/__init__.py Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Update tests/amsterdam/eip8282_builder_execution_requests/spec.py Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * chore(tests): Remove `dataclass` from `Spec` class EIP-8282 * chore(tests): Make test behavior more explicit Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * chore(spec,tests): set EIP-8282 builder addresses for glamsterdam-devnet-6 --------- Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> Co-authored-by: spencer-tb <spencer.tb@ethereum.org> * fix(test-forks): Match EIP contract names * fix(test-plugins): Add eth_config unit test * feat(tests): Mirror EIP-7002/7251 tests * feat(test-types): Implement `SystemContractInteractionMeasuredOutOfGasContract` * fix(tests): Use `SystemContractInteractionMeasuredOutOfGasContract` * fix(test-forks): Lint * fix(tests): Improve modified contract tests * fix(tests): EIP-8282 builder request test fixes (#3090) * fix(tests): exceed per-block max in builder deposit carry-over test * chore(tests): clarify multi-type request test gas limit comment --------- Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> Co-authored-by: spencer-tb <spencer.tb@ethereum.org> Co-authored-by: spencer <spencer.taylor-brown@ethereum.org> Co-authored-by: LouisTsai <q1030176@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
🔗 Related Issues or PRs
N/A.
✅ Checklist
just statictype(scope):.