feat(spec,tests): Implement EIP-8282 by marioevz · Pull Request #2990 · ethereum/execution-specs

marioevz · 2026-06-16T00:09:40Z

🗒️ Description

Implements the current spec iteration of this PR: ethereum/EIPs#11760

🔗 Related Issues or PRs

N/A.

✅ Checklist

All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
```
just static
```
All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
All: Considered updating the online docs in the ./docs/ directory.
All: Set appropriate labels for the changes (only maintainers can apply labels).
Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

codecov · 2026-06-16T00:18:50Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.52%. Comparing base (c5529fe) to head (0c4dac3).

Additional details and impacted files

@@                     Coverage Diff                     @@
##           eips/amsterdam/eip-8282    #2990      +/-   ##
===========================================================
+ Coverage                    81.28%   90.52%   +9.24%     
===========================================================
  Files                          620      535      -85     
  Lines                        36643    32907    -3736     
  Branches                      3311     3024     -287     
===========================================================
+ Hits                         29786    29790       +4     
+ Misses                        6335     2595    -3740     
  Partials                       522      522

Flag	Coverage Δ
unittests	`90.52% <100.00%> (+9.24%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…/256

SamWilsn · 2026-06-17T16:34:01Z

+    type: ClassVar[int] = 3
+    """Placeholder request-type byte pending the EIP-8282 final allocation."""


Should this be Final instead of ClassVar?

I agree that ClassVar leaves the field vulnerable to modifications, but I found at least one pydantic open issue which mentions that the behavior could be updated to the final field being considered an actual field in the instantiated object.

Reasoning being that they want to match the dataclass behavior https://typing.python.org/en/latest/spec/dataclasses.html#dataclass-semantics.

So I think we should keep using ClassVar for now IMO.

That's a really weird divergence.

In any case, I think ClassVar[Final[int]] would be the correct annotation (source)?

SamWilsn · 2026-06-17T16:41:34Z

+    interaction_contract_address: ClassVar[Address] = Address(
+        Spec.BUILDER_DEPOSIT_CONTRACT_ADDRESS
+    )
+    min_fee: ClassVar[int] = Spec.MIN_REQUEST_FEE


Recommending Final where possible again.

See response to previous comment.

…omments

… ignore comments

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

marioevz · 2026-06-18T22:29:13Z

Thanks for the review @SamWilsn! I believe all the comments have been addressed, let me know if the PR is ok.

…net-6

danceratopz · 2026-06-22T10:50:07Z

Hey, @marioevz, will you still add oog tests here? I saw in

refactor(tests): generalize system-contract request test helpers (EIP-6110/7002/7251/7685) #2989
you refactor the 6110 deposits oog tests to their own dedicated module.

Does anyone review how eip-8038 affects system contract interaction? I remember there were some discussion but could not find where it is.

LouisTsai-Csie

Leave some small comment, looks good to me!

One more thing: remember to add system contract in eth_config.

LouisTsai-Csie · 2026-06-22T13:26:24Z

+        """
+        Return the minimum gas limit for the block to be considered valid.
+        """
+        minimum_block_gas_limit = 5_000


nit: could we change it to GasCosts.LIMIT_MINIMUM

LouisTsai-Csie · 2026-06-22T13:28:53Z

+            call_value = builder_deposit_request.value
+        case Address(Spec8282.BUILDER_EXIT_CONTRACT_ADDRESS):
+            # Fabricate a valid builder exit request to the set-code account
+            builder_deposit_request = BuilderExitRequest.from_index(0)


Suggested change

builder_deposit_request = BuilderExitRequest.from_index(0)

builder_exit_request = BuilderExitRequest.from_index(0)

…: ignore, Spec dataclass) (#3018) * refactor(test-forks): Use pkgutil to load contract binaries * refactor(test-forks): Remove pre_allocation_blockchain type: ignore comments * chore(tests): Remove `dataclass` from `Spec` classes

* feat(specs): Implement EIP-8282 * feat(test-forks): Implement EIP-8282 framework changes * feat(tests): Implement EIP-8282 tests * feat(tests): Add EIP-8282 to EIP-7685 tests * fix(test-forks): Update EIP-8282 deposit contract to 537b9c1 * fix(tests): Update EIP-8282 builder deposit contract target/max to 32/256 * fix(tests): Failing tests after update * refactor(test-forks): Introduce `minimum_block_gas_limit` * refactor(test-forks): Update EIP-8282 `empty_block_bal_item_count` * refactor(test-forks): Use pkgutil to load contract binaries * refactor(test-forks): Use pkgutil to load EIP-8282 contract binaries * refactor(test-forks): Remove pre_allocation_blockchain type: ignore comments * refactor(test-forks): Remove EIP-8282 pre_allocation_blockchain type: ignore comments * Update tests/amsterdam/eip8282_builder_execution_requests/__init__.py Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Update tests/amsterdam/eip8282_builder_execution_requests/spec.py Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * chore(tests): Remove `dataclass` from `Spec` class EIP-8282 * chore(tests): Make test behavior more explicit Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * chore(spec,tests): set EIP-8282 builder addresses for glamsterdam-devnet-6 --------- Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> Co-authored-by: spencer-tb <spencer.tb@ethereum.org>

* feat(spec,tests): Implement EIP-8282 (#2990) * feat(specs): Implement EIP-8282 * feat(test-forks): Implement EIP-8282 framework changes * feat(tests): Implement EIP-8282 tests * feat(tests): Add EIP-8282 to EIP-7685 tests * fix(test-forks): Update EIP-8282 deposit contract to 537b9c1 * fix(tests): Update EIP-8282 builder deposit contract target/max to 32/256 * fix(tests): Failing tests after update * refactor(test-forks): Introduce `minimum_block_gas_limit` * refactor(test-forks): Update EIP-8282 `empty_block_bal_item_count` * refactor(test-forks): Use pkgutil to load contract binaries * refactor(test-forks): Use pkgutil to load EIP-8282 contract binaries * refactor(test-forks): Remove pre_allocation_blockchain type: ignore comments * refactor(test-forks): Remove EIP-8282 pre_allocation_blockchain type: ignore comments * Update tests/amsterdam/eip8282_builder_execution_requests/__init__.py Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Update tests/amsterdam/eip8282_builder_execution_requests/spec.py Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * chore(tests): Remove `dataclass` from `Spec` class EIP-8282 * chore(tests): Make test behavior more explicit Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * chore(spec,tests): set EIP-8282 builder addresses for glamsterdam-devnet-6 --------- Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> Co-authored-by: spencer-tb <spencer.tb@ethereum.org> * fix(test-forks): Match EIP contract names * fix(test-plugins): Add eth_config unit test * feat(tests): Mirror EIP-7002/7251 tests * feat(test-types): Implement `SystemContractInteractionMeasuredOutOfGasContract` * fix(tests): Use `SystemContractInteractionMeasuredOutOfGasContract` * fix(test-forks): Lint * fix(tests): Improve modified contract tests * fix(tests): EIP-8282 builder request test fixes (#3090) * fix(tests): exceed per-block max in builder deposit carry-over test * chore(tests): clarify multi-type request test gas limit comment --------- Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> Co-authored-by: spencer-tb <spencer.tb@ethereum.org> Co-authored-by: spencer <spencer.taylor-brown@ethereum.org> Co-authored-by: LouisTsai <q1030176@gmail.com>

marioevz added 4 commits June 15, 2026 17:59

feat(specs): Implement EIP-8282

e632e9a

feat(test-forks): Implement EIP-8282 framework changes

0af20af

feat(tests): Implement EIP-8282 tests

fd1024a

feat(tests): Add EIP-8282 to EIP-7685 tests

1626b71

marioevz marked this pull request as draft June 16, 2026 00:09

marioevz added 3 commits June 16, 2026 07:02

fix(test-forks): Update EIP-8282 deposit contract to 537b9c1

2f4115a

fix(tests): Update EIP-8282 builder deposit contract target/max to 32…

efa416d

…/256

fix(tests): Failing tests after update

f945ac2

SamWilsn self-requested a review June 16, 2026 17:10

marioevz added 2 commits June 16, 2026 13:18

refactor(test-forks): Introduce minimum_block_gas_limit

88c532c

refactor(test-forks): Update EIP-8282 empty_block_bal_item_count

328f86b

SamWilsn reviewed Jun 17, 2026

View reviewed changes

edg-l mentioned this pull request Jun 18, 2026

tracking: glamsterdam-devnet-6 alignment lambdaclass/ethrex#6583

Closed

marioevz mentioned this pull request Jun 18, 2026

Test Release Tracker: glamsterdam-devnet@v6.0.0 #2915

Closed

28 tasks

marioevz added 2 commits June 18, 2026 14:59

refactor(test-forks): Use pkgutil to load contract binaries

f3aa7b7

refactor(test-forks): Use pkgutil to load EIP-8282 contract binaries

8929767

marioevz mentioned this pull request Jun 18, 2026

chore(tests,test-forks): Address #2990 review comments (pkgutil, type: ignore, Spec dataclass) #3018

Merged

7 tasks

marioevz and others added 6 commits June 18, 2026 15:13

refactor(test-forks): Remove pre_allocation_blockchain type: ignore c…

49baec2

…omments

refactor(test-forks): Remove EIP-8282 pre_allocation_blockchain type:…

0205991

… ignore comments

Update tests/amsterdam/eip8282_builder_execution_requests/__init__.py

4b13b2a

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

Update tests/amsterdam/eip8282_builder_execution_requests/spec.py

3c12670

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

chore(tests): Remove dataclass from Spec class EIP-8282

a3dbfd7

chore(tests): Make test behavior more explicit

5670288

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

marioevz marked this pull request as ready for review June 18, 2026 22:28

spencer-tb added a commit that referenced this pull request Jun 18, 2026

feat(spec,tests): Implement EIP-8282 (#2990)

95549ee

chore(spec,tests): set EIP-8282 builder addresses for glamsterdam-dev…

0c4dac3

…net-6

spencer-tb added a commit that referenced this pull request Jun 19, 2026

feat(spec,tests): Implement EIP-8282 (#2990)

fc0d2ae

danceratopz reviewed Jun 22, 2026

View reviewed changes

LouisTsai-Csie approved these changes Jun 22, 2026

View reviewed changes

SamWilsn approved these changes Jun 22, 2026

View reviewed changes

spencer-tb added this to the Glamsterdam Devnet 6 Finalize milestone Jun 30, 2026

spencer-tb mentioned this pull request Jun 30, 2026

Merge Glamsterdam Devnet 6 to Forks/Amsterdam #3068

Closed

20 tasks

marioevz merged commit 34f05ea into ethereum:eips/amsterdam/eip-8282 Jun 30, 2026
35 of 36 checks passed

		type: ClassVar[int] = 3
		"""Placeholder request-type byte pending the EIP-8282 final allocation."""

	builder_deposit_request = BuilderExitRequest.from_index(0)
	builder_exit_request = BuilderExitRequest.from_index(0)

Conversation

marioevz commented Jun 16, 2026

🗒️ Description

🔗 Related Issues or PRs

✅ Checklist

Cute Animal Picture

Uh oh!

codecov Bot commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

marioevz commented Jun 18, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LouisTsai-Csie left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Jun 16, 2026 •

edited

Loading

LouisTsai-Csie left a comment •

edited

Loading