feat(spec,tests): Implement EIP-8282

[marioevz]

🗒️ Description

Implements the current spec iteration of this PR: ethereum/EIPs#11760.

Matches glamsterdam-devnet-6 specs.

🔗 Related Issues or PRs

N/A.

✅ Checklist

• All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:

  just static

• All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
• All: Considered updating the online docs in the ./docs/ directory.
• All: Set appropriate labels for the changes (only maintainers can apply labels).
• Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
• Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
• Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.23%. Comparing base (26f4786) to head (5d7a308).
⚠️ Report is 20 commits behind head on forks/amsterdam.

Additional details and impacted files

@@                 Coverage Diff                 @@
##           forks/amsterdam    #3070      +/-   ##
===================================================
+ Coverage            93.22%   93.23%   +0.01%     
===================================================
  Files                  624      624              
  Lines                36939    36936       -3     
  Branches              3377     3375       -2     
===================================================
+ Hits                 34436    34439       +3     
+ Misses                1709     1704       -5     
+ Partials               794      793       -1     

Flag	Coverage Δ
unittests	93.23% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[LouisTsai-Csie]

Good from my side, some suggestion that could done in follow-up PRs:

• Add builder deposit / exit system contract to eth_config request.
• Do we need a test_eip_mainnet.py / fork transition test (so that we could test out )?

[LouisTsai-Csie]

I have one question related to requests_hash , otherwise it looks good! I like the design of SystemContractInteractionMeasuredOutOfGasContract, amazing!

[LouisTsai-Csie]

Suggested change

requests_hash=Requests(*requests_list),

This looks like a no-op?

requests_hash on Block is a field inherited from Header. We can pass it into Block.requests_hash, but it is never verified against anything:

The header used for verification is rebuilt from the transition-tool (t8n) output.

execution-specs/packages/testing/src/execution_testing/specs/blockchain.py

Lines 891 to 909 in 2d68578

	header = FixtureHeader(
	**(
	transition_tool_output.result.model_dump(
	exclude_none=True,
	exclude={"blob_gas_used", "transactions_trie"},
	)
	| env.model_dump(
	exclude_none=True,
	exclude={"blob_gas_used", "slot_number"},
	)
	),
	blob_gas_used=blob_gas_used,
	transactions_trie=Transaction.list_root(txs),
	extra_data=(
	block.extra_data if block.extra_data is not None else b""
	),
	slot_number=slot_number_value,
	fork=fork,
	)

requests_hash is an output field, so it isn't a t8n input (it's not carried into the Environment) and it isn't merged into the re-built header either, that is, header.requests_hash always comes from the transition output.

execution-specs/packages/testing/src/execution_testing/specs/blockchain.py

Lines 933 to 942 in 2d68578

	requests = Requests(
	requests_lists=list(transition_tool_output.result.requests)
	)
	if Hash(requests) != header.requests_hash:
	raise Exception(
	"Requests root in header does not match the requests "
	"root in the transition tool output: "
	f"{header.requests_hash} != {Hash(requests)}"
	)

I've confirmed this by updating to Block(requests_hash=requests_hash=Requests(*[]),). It sill fills successfully and the fixture header keeps the real t8n value, so the field configuration is unused.

[marioevz]

Yep, and I can confirm that this is a copy-paste error because it's also in the source 7002 test file. We should fix this in the #3071.

[spencer-tb]

LGTM!

Feel free to add these before merge: #3090