Add attrs export to python client#262
Merged
sderickson merged 12 commits intomainfrom Jan 18, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #262 +/- ##
==========================================
+ Coverage 51.65% 51.90% +0.24%
==========================================
Files 37 37
Lines 8425 8437 +12
Branches 1794 1800 +6
==========================================
+ Hits 4352 4379 +27
+ Misses 3757 3741 -16
- Partials 316 317 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rogebrd
reviewed
Jan 11, 2022
Contributor
rogebrd
left a comment
rogebrd
left a comment
There was a problem hiding this comment.
Overall methodology looks sound, just a few clarifying things
Contributor
|
Seems reasonable as a PoC. Let me know once you've got it in a state ready for a full review. |
aelawson
reviewed
Jan 12, 2022
* attribute -> attribute-comment * attrs_list -> attrs_lines * added a test for a line that wasn't covered * made sure to test multiple attributes being included
rogebrd
approved these changes
Jan 12, 2022
6 tasks
sderickson
added a commit
that referenced
this pull request
Jan 25, 2022
In testing 3.3.0 with the Python SDK, turns out routes without the attribute defined have values of "None". This PR tweaks the logic from #262 to handle None, and adds a regression test. Also updates the version to so as a follow I can publish the fix.
6 tasks
sderickson
added a commit
that referenced
this pull request
Feb 1, 2022
Add --attribute-comment field to js_client.py and tsd_client.py, like the one added to python_client.py in #262. This is a prerequisite for dropbox/dropbox-sdk-js#891 which adds scopes to the outputted clients for easier reference. Also adds appropriate testing and updates the docstring for the python_client.py, making it more succinct and aligned with the other two.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the python client generator, adding a command line arg to export route attributes to the documentation string. This way generated docs can include specified attributes, in our case the scope attribute.
Checklist
General Contributing
Is This a Code Change?
Validation
tox?