Skip to content

Fix python client attribute output to handle None#265

Merged
sderickson merged 2 commits intomainfrom
fix-attr-in-python-client
Jan 25, 2022
Merged

Fix python client attribute output to handle None#265
sderickson merged 2 commits intomainfrom
fix-attr-in-python-client

Conversation

@sderickson
Copy link
Copy Markdown
Contributor

@sderickson sderickson commented Jan 24, 2022

In testing 3.3.0 with the Python SDK, turns out routes without the attribute defined have values of "None". This PR tweaks the logic from #262 to handle None, and adds a regression test.

Also updates the version to so as a follow I can publish the fix.

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • Code Change
  • Example/Test Code Change

Validation

  • Have you ran tox?
  • Do the tests pass?

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 24, 2022

Codecov Report

Merging #265 (649f327) into main (f84a8a7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #265   +/-   ##
=======================================
  Coverage   51.90%   51.90%           
=======================================
  Files          37       37           
  Lines        8437     8437           
  Branches     1800     1800           
=======================================
  Hits         4379     4379           
  Misses       3741     3741           
  Partials      317      317           
Flag Coverage Δ
unit 51.90% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
stone/backends/python_client.py 46.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f84a8a7...649f327. Read the comment docs.

@sderickson sderickson requested a review from rogebrd January 24, 2022 22:43
@sderickson sderickson merged commit 90dd831 into main Jan 25, 2022
@sderickson sderickson deleted the fix-attr-in-python-client branch January 25, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants