Fix python client attribute output to handle None#265
Merged
sderickson merged 2 commits intomainfrom Jan 25, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #265 +/- ##
=======================================
Coverage 51.90% 51.90%
=======================================
Files 37 37
Lines 8437 8437
Branches 1800 1800
=======================================
Hits 4379 4379
Misses 3741 3741
Partials 317 317
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rogebrd
approved these changes
Jan 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In testing 3.3.0 with the Python SDK, turns out routes without the attribute defined have values of "None". This PR tweaks the logic from #262 to handle None, and adds a regression test.
Also updates the version to so as a follow I can publish the fix.
Checklist
General Contributing
Is This a Code Change?
Validation
tox?