Add --attribute-comment argument to JS and TSD clients#268
Merged
sderickson merged 6 commits intomainfrom Feb 1, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #268 +/- ##
==========================================
+ Coverage 51.90% 52.02% +0.11%
==========================================
Files 37 37
Lines 8437 8458 +21
Branches 1800 1810 +10
==========================================
+ Hits 4379 4400 +21
Misses 3741 3741
Partials 317 317
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
rogebrd
approved these changes
Feb 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
--attribute-commentfield tojs_client.pyandtsd_client.py, like the one added topython_client.pyin #262. This is a prerequisite for dropbox/dropbox-sdk-js#891 which adds scopes to the outputted clients for easier reference.Also adds appropriate testing and updates the docstring for the
python_client.py, making it more succinct and aligned with the other two.Checklist
General Contributing
Is This a Code Change?
Validation
tox?