Skip to content

[Arm64] ASIMD StorePair StorePairNonTemporal#39240

Merged
echesakov merged 11 commits into
dotnet:masterfrom
echesakov:Arm64-ASIMD-StorePair
Jul 14, 2020
Merged

[Arm64] ASIMD StorePair StorePairNonTemporal#39240
echesakov merged 11 commits into
dotnet:masterfrom
echesakov:Arm64-ASIMD-StorePair

Conversation

@echesakov

@echesakov echesakov commented Jul 14, 2020

Copy link
Copy Markdown
Contributor
  • StorePair
  • StorePairNonTemporal
  • StorePairScalar
  • StorePairScalarNonTemporal

Fixes #33532

@Dotnet-GitSync-Bot

Dotnet-GitSync-Bot commented Jul 14, 2020

Copy link
Copy Markdown
Collaborator

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI new-api-needs-documentation labels Jul 14, 2020
@ghost

ghost commented Jul 14, 2020

Copy link
Copy Markdown

Tagging subscribers to this area: @tannergooding
Notify danmosemsft if you want to be subscribed.

@echesakov echesakov added arch-arm64 and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI new-api-needs-documentation labels Jul 14, 2020
@echesakov

echesakov commented Jul 14, 2020

Copy link
Copy Markdown
Contributor Author

@CarolEidt @tannergooding @TamarChristinaArm PTAL

@TamarChristinaArm

TamarChristinaArm commented Jul 14, 2020

Copy link
Copy Markdown
Contributor

@echesakovMSFT awesome, thanks! just for my own understanding, I'm guessing pointers are a special case already? As I don't see any special code to handle the address in the PR.

CarolEidt
CarolEidt approved these changes Jul 14, 2020
View reviewed changes

@CarolEidt CarolEidt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - so nice to see continued payoff for all the investment in table-based codegen and testing!

@echesakov

echesakov commented Jul 14, 2020

Copy link
Copy Markdown
Contributor Author

awesome, thanks! just for my own understanding, I'm guessing pointers are a special case already? As I don't see any special code to handle the address in the PR.

@TamarChristinaArm Yes, pointer arguments were supported already (e.g. for LoadVector64, LoadVector128, Store). We should implement the addressing mode optimization in the future as in #33676

@echesakov

echesakov commented Jul 14, 2020

Copy link
Copy Markdown
Contributor Author

runtime (Build Browser wasm Release AllSubsets_Mono) is failing due to #39238
No luck of getting it green on the second attempt, ignoring

@echesakov echesakov merged commit 43b2578 into dotnet:master Jul 14, 2020
@echesakov echesakov deleted the Arm64-ASIMD-StorePair branch July 14, 2020 20:23
@echesakov echesakov mentioned this pull request Jul 14, 2020
Closed
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tannergooding tannergooding tannergooding approved these changes
+1 more reviewer
@CarolEidt CarolEidt CarolEidt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

arch-arm64 area-System.Runtime.Intrinsics

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

[Arm64] Store Pair of SIMD&FP registers

6 participants

@echesakov @Dotnet-GitSync-Bot @TamarChristinaArm @CarolEidt @tannergooding @karelz