Skip to content

[Arm64] ASIMD StorePair StorePairNonTemporal #39240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
echesakov merged 11 commits into from
Jul 14, 2020
Merged

[Arm64] ASIMD StorePair StorePairNonTemporal #39240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5373142
Add StorePair and StorePairNonTemporal in AdvSimd.cs AdvSimd.Platform…
echesakov Jul 9, 2020
7e51617
Update System.Runtime.Intrinsics.cs
echesakov Jul 13, 2020
1132547
Add StorePair{Scalar} and StorePair{Scalar}NonTemporal in hwintrinsic…
echesakov Jul 13, 2020
fb79cdf
Add StorePair{Scalar} and StorePair{Scalar}NonTemporal in hwintrinsic…
echesakov Jul 13, 2020
09e7826
Add StoreBinOpTest.template
echesakov Jul 10, 2020
139b38c
Add StorePair in GenerateTests.csx
echesakov Jul 10, 2020
862a677
Add StorePairNonTemporal in GenerateTests.csx
echesakov Jul 10, 2020
3e6e69c
Add StorePairScalar and StorePairScalarNonTemporal in GenerateTests.csx
echesakov Jul 10, 2020
0ef00bc
Update Helpers.cs Helpers.tt
echesakov Jul 13, 2020
db6d53f
Update AdvSimd.Arm64/
echesakov Jul 13, 2020
82b789b
Update the remaining tests in Arm/
echesakov Jul 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/coreclr/src/jit/hwintrinsiccodegenarm64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -718,6 +718,16 @@ void CodeGen::genHWIntrinsic(GenTreeHWIntrinsic* node)
}
break;

case NI_AdvSimd_Arm64_StorePair:
case NI_AdvSimd_Arm64_StorePairNonTemporal:
GetEmitter()->emitIns_R_R_R(ins, emitSize, op2Reg, op3Reg, op1Reg);
break;

case NI_AdvSimd_Arm64_StorePairScalar:
case NI_AdvSimd_Arm64_StorePairScalarNonTemporal:
GetEmitter()->emitIns_R_R_R(ins, emitTypeSize(intrin.baseType), op2Reg, op3Reg, op1Reg);
break;

case NI_Vector64_CreateScalarUnsafe:
case NI_Vector128_CreateScalarUnsafe:
if (intrin.op1->isContainedFltOrDblImmed())
Expand Down
4 changes: 4 additions & 0 deletions src/coreclr/src/jit/hwintrinsiclistarm64.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,10 @@ HARDWARE_INTRINSIC(AdvSimd_Arm64, ShiftRightArithmeticRoundedNarrowingSaturateUn
HARDWARE_INTRINSIC(AdvSimd_Arm64, ShiftRightLogicalNarrowingSaturateScalar, 8, 2, {INS_uqshrn, INS_uqshrn, INS_uqshrn, INS_uqshrn, INS_uqshrn, INS_uqshrn, INS_invalid, INS_invalid, INS_invalid, INS_invalid}, HW_Category_ShiftRightByImmediate, HW_Flag_HasImmediateOperand|HW_Flag_SIMDScalar)
HARDWARE_INTRINSIC(AdvSimd_Arm64, ShiftRightLogicalRoundedNarrowingSaturateScalar, 8, 2, {INS_uqrshrn, INS_uqrshrn, INS_uqrshrn, INS_uqrshrn, INS_uqrshrn, INS_uqrshrn, INS_invalid, INS_invalid, INS_invalid, INS_invalid}, HW_Category_ShiftRightByImmediate, HW_Flag_HasImmediateOperand|HW_Flag_SIMDScalar)
HARDWARE_INTRINSIC(AdvSimd_Arm64, Sqrt, -1, 1, {INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_fsqrt, INS_fsqrt}, HW_Category_SIMD, HW_Flag_NoFlag)
HARDWARE_INTRINSIC(AdvSimd_Arm64, StorePair, -1, 3, {INS_stp, INS_stp, INS_stp, INS_stp, INS_stp, INS_stp, INS_stp, INS_stp, INS_stp, INS_stp}, HW_Category_MemoryStore, HW_Flag_BaseTypeFromSecondArg|HW_Flag_SpecialCodeGen)
HARDWARE_INTRINSIC(AdvSimd_Arm64, StorePairScalar, 8, 3, {INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_stp, INS_stp, INS_invalid, INS_invalid, INS_stp, INS_invalid}, HW_Category_MemoryStore, HW_Flag_BaseTypeFromSecondArg|HW_Flag_SpecialCodeGen)
HARDWARE_INTRINSIC(AdvSimd_Arm64, StorePairScalarNonTemporal, 8, 3, {INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_stnp, INS_stnp, INS_invalid, INS_invalid, INS_stnp, INS_invalid}, HW_Category_MemoryStore, HW_Flag_BaseTypeFromSecondArg|HW_Flag_SpecialCodeGen)
HARDWARE_INTRINSIC(AdvSimd_Arm64, StorePairNonTemporal, -1, 3, {INS_stnp, INS_stnp, INS_stnp, INS_stnp, INS_stnp, INS_stnp, INS_stnp, INS_stnp, INS_stnp, INS_stp}, HW_Category_MemoryStore, HW_Flag_BaseTypeFromSecondArg|HW_Flag_SpecialCodeGen)
HARDWARE_INTRINSIC(AdvSimd_Arm64, Subtract, 16, 2, {INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_invalid, INS_fsub}, HW_Category_SIMD, HW_Flag_NoFlag)
HARDWARE_INTRINSIC(AdvSimd_Arm64, SubtractSaturateScalar, 8, 2, {INS_sqsub, INS_uqsub, INS_sqsub, INS_uqsub, INS_sqsub, INS_uqsub, INS_invalid, INS_invalid, INS_invalid, INS_invalid}, HW_Category_SIMD, HW_Flag_SIMDScalar)
HARDWARE_INTRINSIC(AdvSimd_Arm64, TransposeEven, -1, 2, {INS_trn1, INS_trn1, INS_trn1, INS_trn1, INS_trn1, INS_trn1, INS_trn1, INS_trn1, INS_trn1, INS_trn1}, HW_Category_SIMD, HW_Flag_NoFlag)
Expand Down
230 changes: 230 additions & 0 deletions .../System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/AdvSimd.PlatformNotSupported.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2715,6 +2715,236 @@ internal Arm64() { }
/// </summary>
public static Vector128<float> Sqrt(Vector128<float> value) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STP Dt1, Dt2, [Xn]
/// </summary>
public static unsafe void StorePair(byte* address, Vector64<byte> value1, Vector64<byte> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STP Dt1, Dt2, [Xn]
/// </summary>
public static unsafe void StorePair(double* address, Vector64<double> value1, Vector64<double> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STP Dt1, Dt2, [Xn]
/// </summary>
public static unsafe void StorePair(short* address, Vector64<short> value1, Vector64<short> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STP Dt1, Dt2, [Xn]
/// </summary>
public static unsafe void StorePair(int* address, Vector64<int> value1, Vector64<int> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STP Dt1, Dt2, [Xn]
/// </summary>
public static unsafe void StorePair(long* address, Vector64<long> value1, Vector64<long> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STP Dt1, Dt2, [Xn]
/// </summary>
public static unsafe void StorePair(sbyte* address, Vector64<sbyte> value1, Vector64<sbyte> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STP Dt1, Dt2, [Xn]
/// </summary>
public static unsafe void StorePair(float* address, Vector64<float> value1, Vector64<float> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STP Dt1, Dt2, [Xn]
/// </summary>
public static unsafe void StorePair(ushort* address, Vector64<ushort> value1, Vector64<ushort> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STP Dt1, Dt2, [Xn]
/// </summary>
public static unsafe void StorePair(uint* address, Vector64<uint> value1, Vector64<uint> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STP Dt1, Dt2, [Xn]
/// </summary>
public static unsafe void StorePair(ulong* address, Vector64<ulong> value1, Vector64<ulong> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STP Qt1, Qt2, [Xn]
/// </summary>
public static unsafe void StorePair(byte* address, Vector128<byte> value1, Vector128<byte> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STP Qt1, Qt2, [Xn]
/// </summary>
public static unsafe void StorePair(double* address, Vector128<double> value1, Vector128<double> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STP Qt1, Qt2, [Xn]
/// </summary>
public static unsafe void StorePair(short* address, Vector128<short> value1, Vector128<short> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STP Qt1, Qt2, [Xn]
/// </summary>
public static unsafe void StorePair(int* address, Vector128<int> value1, Vector128<int> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STP Qt1, Qt2, [Xn]
/// </summary>
public static unsafe void StorePair(long* address, Vector128<long> value1, Vector128<long> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STP Qt1, Qt2, [Xn]
/// </summary>
public static unsafe void StorePair(sbyte* address, Vector128<sbyte> value1, Vector128<sbyte> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STP Qt1, Qt2, [Xn]
/// </summary>
public static unsafe void StorePair(float* address, Vector128<float> value1, Vector128<float> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STP Qt1, Qt2, [Xn]
/// </summary>
public static unsafe void StorePair(ushort* address, Vector128<ushort> value1, Vector128<ushort> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STP Qt1, Qt2, [Xn]
/// </summary>
public static unsafe void StorePair(uint* address, Vector128<uint> value1, Vector128<uint> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STP Qt1, Qt2, [Xn]
/// </summary>
public static unsafe void StorePair(ulong* address, Vector128<ulong> value1, Vector128<ulong> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STNP Dt1, Dt2, [Xn]
/// </summary>
public static unsafe void StorePairNonTemporal(byte* address, Vector64<byte> value1, Vector64<byte> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STNP Dt1, Dt2, [Xn]
/// </summary>
public static unsafe void StorePairNonTemporal(double* address, Vector64<double> value1, Vector64<double> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STNP Dt1, Dt2, [Xn]
/// </summary>
public static unsafe void StorePairNonTemporal(short* address, Vector64<short> value1, Vector64<short> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STNP Dt1, Dt2, [Xn]
/// </summary>
public static unsafe void StorePairNonTemporal(int* address, Vector64<int> value1, Vector64<int> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STNP Dt1, Dt2, [Xn]
/// </summary>
public static unsafe void StorePairNonTemporal(long* address, Vector64<long> value1, Vector64<long> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STNP Dt1, Dt2, [Xn]
/// </summary>
public static unsafe void StorePairNonTemporal(sbyte* address, Vector64<sbyte> value1, Vector64<sbyte> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STNP Dt1, Dt2, [Xn]
/// </summary>
public static unsafe void StorePairNonTemporal(float* address, Vector64<float> value1, Vector64<float> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STNP Dt1, Dt2, [Xn]
/// </summary>
public static unsafe void StorePairNonTemporal(ushort* address, Vector64<ushort> value1, Vector64<ushort> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STNP Dt1, Dt2, [Xn]
/// </summary>
public static unsafe void StorePairNonTemporal(uint* address, Vector64<uint> value1, Vector64<uint> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STNP Dt1, Dt2, [Xn]
/// </summary>
public static unsafe void StorePairNonTemporal(ulong* address, Vector64<ulong> value1, Vector64<ulong> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STNP Qt1, Qt2, [Xn]
/// </summary>
public static unsafe void StorePairNonTemporal(byte* address, Vector128<byte> value1, Vector128<byte> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STNP Qt1, Qt2, [Xn]
/// </summary>
public static unsafe void StorePairNonTemporal(double* address, Vector128<double> value1, Vector128<double> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STNP Qt1, Qt2, [Xn]
/// </summary>
public static unsafe void StorePairNonTemporal(short* address, Vector128<short> value1, Vector128<short> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STNP Qt1, Qt2, [Xn]
/// </summary>
public static unsafe void StorePairNonTemporal(int* address, Vector128<int> value1, Vector128<int> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STNP Qt1, Qt2, [Xn]
/// </summary>
public static unsafe void StorePairNonTemporal(long* address, Vector128<long> value1, Vector128<long> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STNP Qt1, Qt2, [Xn]
/// </summary>
public static unsafe void StorePairNonTemporal(sbyte* address, Vector128<sbyte> value1, Vector128<sbyte> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STNP Qt1, Qt2, [Xn]
/// </summary>
public static unsafe void StorePairNonTemporal(float* address, Vector128<float> value1, Vector128<float> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STNP Qt1, Qt2, [Xn]
/// </summary>
public static unsafe void StorePairNonTemporal(ushort* address, Vector128<ushort> value1, Vector128<ushort> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STNP Qt1, Qt2, [Xn]
/// </summary>
public static unsafe void StorePairNonTemporal(uint* address, Vector128<uint> value1, Vector128<uint> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STNP Qt1, Qt2, [Xn]
/// </summary>
public static unsafe void StorePairNonTemporal(ulong* address, Vector128<ulong> value1, Vector128<ulong> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STP St1, St2, [Xn]
/// </summary>
public static unsafe void StorePairScalar(int* address, Vector64<int> value1, Vector64<int> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STP St1, St2, [Xn]
/// </summary>
public static unsafe void StorePairScalar(float* address, Vector64<float> value1, Vector64<float> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STP St1, St2, [Xn]
/// </summary>
public static unsafe void StorePairScalar(uint* address, Vector64<uint> value1, Vector64<uint> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STNP St1, St2, [Xn]
/// </summary>
public static unsafe void StorePairScalarNonTemporal(int* address, Vector64<int> value1, Vector64<int> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STNP St1, St2, [Xn]
/// </summary>
public static unsafe void StorePairScalarNonTemporal(float* address, Vector64<float> value1, Vector64<float> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// A64: STNP St1, St2, [Xn]
/// </summary>
public static unsafe void StorePairScalarNonTemporal(uint* address, Vector64<uint> value1, Vector64<uint> value2) { throw new PlatformNotSupportedException(); }

/// <summary>
/// float64x2_t vsubq_f64 (float64x2_t a, float64x2_t b)
/// A64: FSUB Vd.2D, Vn.2D, Vm.2D
Expand Down
Loading