Repository navigation
translation(ru): fixed format of money in the article №5 - #83
Fristail27 wants to merge 1 commit into
Conversation
3e2063b to
4693635
Compare
4693635 to
c8e8f81
Compare
CN yi-yuan figures were off by 10x and shown as rubles. Align with EN: 623.486 / 161.031 billion yuan, yuan units in plain and benefit lines. Based on review of PR #83 by Fristail27.
CN yi-yuan figures were off by 10x and shown as rubles. Align with EN: 623.486 / 161.031 billion yuan, yuan units in plain and benefit lines. Based on review of PR #83 by Fristail27.
|
Landed via #88 (polished yuan units + dropped the non-prize=full-sales clause). Thanks @Fristail27 for catching the 10x / currency bug. |
|
@dlgrv Honestly, this is disappointing. The RU chapters were machine-translated and published with script checks only. The lottery item had rubles instead of yuan and figures off by 10x, which is an automatic fail under hard rule #1 of your own QUALITY.md. And instead of merging my PR or leaving a review comment, you re-committed my changes under your own name. A line in the description doesn't make me the author of the commit. This isn't how open-source contributions are usually handled on GitHub. The accepted practice is to review the PR, push fixes to the contributor's branch, or at least keep the contributor as a co-author ( I've found a few more serious errors in the RU chapters. I think I'll report them upstream in eternity4719/HowToLiveBetter instead, so the original authors know about the quality of this translation. |
|
@Fristail27 You're right about the process, and I'm sorry. PR #83 should have been reviewed and merged (or fixed on your branch with Co-authored-by). Instead the fix landed via #88 under my name. That was a mistake — agent-assisted workflow, I didn't catch the attribution miss in time. Credit for catching the 10× / currency bug is yours; a line in the PR description was not enough. Going forward: if you open a PR or issue here, I'll make sure you're credited properly — merge your PR when it's green, or push follow-ups to your branch / keep Co-authored-by. I won't re-land your work as a solo commit again. If you've found more RU errors, please file them on this repo (issue or PR). We'll review and merge under your authorship. A small corrective PR from you would also be the cleanest way to get the contribution on the record — happy to merge that. Sorry again for the clumsy handling, and thanks for the careful read of ch05. |
…、三十二条,国办发〔2009〕66 号不得退保、统筹基金按 12% 转、男 50 女 40 留原参保地、领取地满 10 年规则,医保办发〔2021〕43 号断缴 3 个月以上等待期原则上不超过 6 个月);第 7 节第 18 条、第 31 节第 11 条补指路
…路到已有条目;README、检索页挂链接,CLAUDE.md 目录简介和统计同步
Fixed the format of money, because current format is not clear and doesn't fit the main format in this article.
For example, main format looks like:
And there were mistakes with 0.
And of course 亿元 means 100 millions yuan so 6234b rub and 1610b rub are wrong