Skip to content

translation(ru): fixed format of money in the article №5 - #83

Closed
Fristail27 wants to merge 1 commit into
dlgrv:mainfrom
Fristail27:fix_sum_format
Closed

Fristail27 wants to merge 1 commit into
dlgrv:mainfrom
Fristail27:fix_sum_format

Conversation

@Fristail27

@Fristail27 Fristail27 commented Sep 29, 2026 •

Copy link
Copy Markdown

Fixed the format of money, because current format is not clear and doesn't fit the main format in this article.

For example, main format looks like:

Простыми словами: Согласно правилам, минимальная доля выручки, выделяемая на призы в лотереях типа «лотто» и цифровых, составляет 50%, а в «Двойном шаре» — 51%. Это значит, что в среднем за долгий период каждый вложенный вами рубль принесёт лишь 0,51 рубля, а 49% вы теряете. В 2024 году по всей стране было продано лотерейных билетов на 6234,86 млрд рублей, из которых 1610,31 млрд рублей направились в фонд благотворительности и не стали призами для игроков. В общей сложности сумма, не пошедшая на выплату призов, составила 623486000000 рублей, а сумма, направленная в фонд благотворительности, — 161031000000 рублей.

And there were mistakes with 0.

And of course 亿元 means 100 millions yuan so 6234b rub and 1610b rub are wrong

@Fristail27
Fristail27 force-pushed the fix_sum_format branch 6 times, most recently from 3e2063b to 4693635 Compare September 29, 2026 22:05
dlgrv added a commit that referenced this pull request Sep 30, 2026
CN yi-yuan figures were off by 10x and shown as rubles. Align with EN:
623.486 / 161.031 billion yuan, yuan units in plain and benefit lines.
Based on review of PR #83 by Fristail27.
dlgrv added a commit that referenced this pull request Sep 30, 2026
CN yi-yuan figures were off by 10x and shown as rubles. Align with EN:
623.486 / 161.031 billion yuan, yuan units in plain and benefit lines.
Based on review of PR #83 by Fristail27.
@dlgrv

dlgrv commented Sep 30, 2026

Copy link
Copy Markdown
Owner

Landed via #88 (polished yuan units + dropped the non-prize=full-sales clause). Thanks @Fristail27 for catching the 10x / currency bug.

@dlgrv dlgrv closed this Sep 30, 2026
@Fristail27
Fristail27 deleted the fix_sum_format branch September 30, 2026 09:14
@Fristail27

Copy link
Copy Markdown
Author

@dlgrv Honestly, this is disappointing. The RU chapters were machine-translated and published with script checks only. The lottery item had rubles instead of yuan and figures off by 10x, which is an automatic fail under hard rule #1 of your own QUALITY.md. And instead of merging my PR or leaving a review comment, you re-committed my changes under your own name. A line in the description doesn't make me the author of the commit.

This isn't how open-source contributions are usually handled on GitHub. The accepted practice is to review the PR, push fixes to the contributor's branch, or at least keep the contributor as a co-author (Co-authored-by, which GitHub supports for exactly this case). Taking someone's changes and publishing them as your own commit goes against basic contribution etiquette.

I've found a few more serious errors in the RU chapters. I think I'll report them upstream in eternity4719/HowToLiveBetter instead, so the original authors know about the quality of this translation.

@dlgrv

dlgrv commented Oct 5, 2026

Copy link
Copy Markdown
Owner

@Fristail27 You're right about the process, and I'm sorry.

PR #83 should have been reviewed and merged (or fixed on your branch with Co-authored-by). Instead the fix landed via #88 under my name. That was a mistake — agent-assisted workflow, I didn't catch the attribution miss in time. Credit for catching the 10× / currency bug is yours; a line in the PR description was not enough.

Going forward: if you open a PR or issue here, I'll make sure you're credited properly — merge your PR when it's green, or push follow-ups to your branch / keep Co-authored-by. I won't re-land your work as a solo commit again.

If you've found more RU errors, please file them on this repo (issue or PR). We'll review and merge under your authorship. A small corrective PR from you would also be the cleanest way to get the contribution on the record — happy to merge that.

Sorry again for the clumsy handling, and thanks for the careful read of ch05.

@Fristail27

Copy link
Copy Markdown
Author

@dlgrv Thanks for acknowledging this. I found another error in RU chapter 09, item 24: yuan became rubles, Chinese law became “УК РФ,” and several figures were mistranslated. I’ve prepared a correction against the Chinese original and will submit a separate PR.

#145

dlgrv pushed a commit that referenced this pull request Oct 9, 2026
…、三十二条,国办发〔2009〕66 号不得退保、统筹基金按 12% 转、男 50 女 40 留原参保地、领取地满 10 年规则,医保办发〔2021〕43 号断缴 3 个月以上等待期原则上不超过 6 个月);第 7 节第 18 条、第 31 节第 11 条补指路
dlgrv pushed a commit that referenced this pull request Oct 9, 2026
@dlgrv dlgrv mentioned this pull request Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants