Repository navigation
feat(new-workspace): one row of recent folders with a +N chip on wide screens - #848
Merged
Merged
Conversation
… screens A wider screen wrapped up to eight folder chips over several rows. It now shows as many as one row holds, measured from the chips' own widths, and a +N chip whose menu lists the rest with their whole paths; a phone keeps its swiped row. RowMenu gains a paths variant (a long path gives way before its label) and draws above the dialog it is opened from. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to No confirmed issue remains that requires a fix before merge. Pre-merge checks |
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 9 files. (3 skipped: 3… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
Check name Status Explanation Title check The title clearly and concisely describes the main change: displaying recent folders in one row with a +N chip on wide screens. Description check The description explains the problem, resulting behavior, implementation details, translations, and validation results. It uses a Tests section instead of the template's Validation heading, but it pro… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 9 files. (3 skipped: 3 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
-
📝 Generate docstrings 💡
-
-
- Commit to this branch
- Create a new PR
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
…chip's focus ring shows whole Review findings (Codex, pre-merge): the hidden row that measures every chip was as wide as all of them and scrolled the dialog's body sideways; it sits in a clipped box the size of the frame now. The chip row clipped the focus outline of a chip; only chips that fit are drawn, so it clips nothing. The regression asserts the dialog never scrolls sideways. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
# Conflicts: # CHANGELOG.md
devswha
added a commit
that referenced
this pull request
Oct 12, 2026
## Change Release 0.4.8, from main at ca6db6e (20 PRs since v0.4.7: the 0.4.7 mobile walk-through fixes, two contributor PRs and the revived #793). - `package.json` and `herdr-plugin.toml`: 0.4.8. - CHANGELOG: `[Unreleased]` becomes `[0.4.8] - 2026-10-12`, with the compare links. Twelve entries that had no PR link get theirs (#835 #837 #838 #840 #842 #843 #844+#848 #845 #847 #849 #851 #852). A Maintenance line says the remote-PC runtime is now version 27. - `release-summaries.json`: 0.4.8 in en/ko/ja/zh/tr (3 new, 6 improved, 8 fixed). The Turkish lines are not checked by a native speaker. - `REMOTE_BUNDLE_VERSION` 26 -> 27: #836 adds the `pending-hold` server feature and #787 serves precompressed assets, so `remote-v27` is published before the app release. Every PR merged since v0.4.7 is linked in the section: #787 #788 #793 #835 #836 #837 #838 #839 #840 #841 #842 #843 #844 #845 #846 #847 #848 #849 #851 #852. ## Validation - `bun scripts/release-notes.ts 0.4.8` renders the summaries and the full changelog (116 lines). - `bun run check fast`: generated types, typecheck, build and 2800+ unit tests pass. ## Release After this merges and its CI on `main` passes: push `remote-v27`, wait for its release, then run the Release workflow with `0.4.8`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #844, from the user's review: on a desktop, up to eight recent-folder chips wrapped onto two or three rows. They asked for a tidier layout and picked "one row + a +N chip".
Change
RecentFolderChips(used byNewSessionDialog):≤640pxor coarse pointer): unchanged, one row swiped sideways;chipsThatFitkeeps as many as fit with room for a+Nchip (re-measured on resize and once fonts load).+Nopens aRowMenulisting the rest (basename + full path); picking one fills Directory like a chip.RowMenu:variant="paths": wider menu, the path hint shrinks with an ellipsis before the label does;aria-modalsurface getsis-over-modal(z-index above--z-modal), so it is no longer drawn behind the dialog.{n} more recent foldersin ko/ja/zh/tr.Tests
chipsThatFit.recent-folders-regression(1440/1920/390 × dark/light): reads what the dialog offers as the visible chips plus the+Nmenu, in order; asserts a wide screen stays on one row and shows+Nwith four folders,+N's count matches the list, Escape closes the list and not the dialog, and picks a folder from the menu when its chip is not shown.bun run check fast,ui-regression,deep-link-demo-regression,sidebar-activity-demo-regressionpass.+4, the list drawn over the dialog with paths cut before names.🤖 Generated with Claude Code