Repository navigation
fix(updates): keep the update line to one row on any width - #845
Merged
Merged
Conversation
On a phone the line after an update wrapped its sentence or pushed Dismiss onto a second row, and an install's step sat above its bar. The release's line now never wraps: the sentence ends in an ellipsis (full text in its title), buttons keep their width, Dismiss is an x icon like a PC's line, and the step, count and bar share one row. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 17 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review finding (Codex, pre-merge): on a phone the ellipsis cut "Save unsent drafts before reloading" to its first words, with the whole sentence only in a title a touch screen cannot show, before a button that reloads at once. That one line wraps instead; the other states stay one row. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
# Conflicts: # CHANGELOG.md
devswha
added a commit
that referenced
this pull request
Oct 12, 2026
## Change Release 0.4.8, from main at ca6db6e (20 PRs since v0.4.7: the 0.4.7 mobile walk-through fixes, two contributor PRs and the revived #793). - `package.json` and `herdr-plugin.toml`: 0.4.8. - CHANGELOG: `[Unreleased]` becomes `[0.4.8] - 2026-10-12`, with the compare links. Twelve entries that had no PR link get theirs (#835 #837 #838 #840 #842 #843 #844+#848 #845 #847 #849 #851 #852). A Maintenance line says the remote-PC runtime is now version 27. - `release-summaries.json`: 0.4.8 in en/ko/ja/zh/tr (3 new, 6 improved, 8 fixed). The Turkish lines are not checked by a native speaker. - `REMOTE_BUNDLE_VERSION` 26 -> 27: #836 adds the `pending-hold` server feature and #787 serves precompressed assets, so `remote-v27` is published before the app release. Every PR merged since v0.4.7 is linked in the section: #787 #788 #793 #835 #836 #837 #838 #839 #840 #841 #842 #843 #844 #845 #846 #847 #848 #849 #851 #852. ## Validation - `bun scripts/release-notes.ts 0.4.8` renders the summaries and the full changelog (116 lines). - `bun run check fast`: generated types, typecheck, build and 2800+ unit tests pass. ## Release After this merges and its CI on `main` passes: push `remote-v27`, wait for its release, then run the Release workflow with `0.4.8`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
The update line above the pane (
UpdateNotice) wrapped untidily, mostly on a phone:Every state of this line is now one row on any width:
title. Buttons keep their width.Scoped to the release line (
.update-notice.is-line). The telemetry notice and the PC bridge line share.update-noticeand keep wrapping as before.Validation
bun run check fast: generated types, typecheck, build pass; unit tests 2749 pass, 0 fail.scripts/update-notice-regression.tsnow asserts that the available, installing and failed states draw as one row at 390px (sentence, buttons, step and bar share one vertical centre; the sentence does not wrap). Ran it alone against a fresh build: passes. Against a build with the old CSS it fails oninstalling: the line is one row(rows 74,69,85)./api/updatesand/api/updates/installed: available, installing, failed, reload and after-update are each one row.🤖 Generated with Claude Code