Repository navigation
fix(chat): an answer before a wake-up nobody typed is not folded into the next turn's work - #483
Merged
Merged
Conversation
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (3)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
devswha
added a commit
that referenced
this pull request
Oct 6, 2026
Its branch had appended the tab-strip sentence to the fonts entry under [0.3.50], which was released before #479 merged. The sentence is its own entry under [0.3.51] Fixed, and the 0.3.50 entry links #473 alone again. Bumps package.json and herdr-plugin.toml to 0.3.51 and moves the Unreleased notes under [0.3.51] - 2026-10-06, with the compare link. Raises the remote PC bundle to 18: #368 adds the `take-over` capability the bridge advertises, and #477, #483, #484, #485 and #486 change what the bridge reads (transcripts, prompts, process start times, a pane's Codex store), so a remote PC on bundle 17 keeps the old behaviour until its bridge is updated. Push the `remote-v18` tag and let the bundle workflow publish before running release.yml. Carries #368 #477 #479 #481 #482 #483 #484 #485 #486 #487 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
In the chat of an OmO pane (and omp, gjc, pi: they share
parseOmpTranscript), adjacent assistant messages merged into one turn unless a user message or a shown notice came between them. OmO wakes its agent with hiddencustom_messagerecords (senpi-monitor:notification,senpi-terminal:notification,goal-continuation, ... alldisplay: false). #477 draws the background-task wake as a card, but every other wake still merged the work after it into the turn before. The chat shows only the text after a turn's last action as the answer, so the earlier final answer was folded under "Worked for".Seen live: a 6-minute review turn ended with the full review (
stopReason: "stop"), a monitor notification woke the agent 7 ms later, and it wrote one short line. The chat showed "Worked for 5m 43s" and the short line only; the review was inside the fold while the terminal showed it.The fix: an assistant message that stopped for good (
stopReason: "stop") ends its turn, so the next assistant message starts a new one. This covers any wake, named or not, without listing custom types.toolUseanderror(OmO retries after an error) keep merging as before. Hiddencustom_messagerecords are not used as the boundary themselves, because some (omo-kibitzer:recall,environment-context,omo-memory:notice) are injected mid-turn.Validation
bun run typecheck: clean.bun run test:unit: 1376 pass, 0 fail.server/conversation.test.ts: answer, hidden monitor notification, short answer → two assistant turns, the first ending on its answer.splitTurn) are "Codex 결과를 기다리는 중…", "Ask: feat(terminal): 다른 웹 UI 서버가 연 pane을 여기서 열기로 가져오기 #368 리뷰…" and "이 알림은 이미 반영된…", instead of one turn answering only the last.Not tested