Repository navigation
feat(settings): one row each for agents order, thinking and dictation tidying - #3117
Conversation
… tidying Agents order offers By state beside Workspaces and Activity (this device's grouping, with Within a state under it), Show thinking is Hidden, Folded or Expanded, and Tidy dictated text is Off, Chat, Terminal or Both. Each row reads and writes the same two settings as before, so every earlier choice is kept.
|
Caution Review failedThe pull request is closed. Summary
Merge Risk:
|
Review (omo + Codex Terra xhigh)omo: CLEAR at a565283. Codex: no HIGH or MEDIUM. It found no defect in the stored-value mappings, shared versus device-only sync, visibility conditions, translations or Segmented markup.
CodeRabbit had not reviewed when this was written. |
|
Local merge gate (owner-approved): |
… in ui-regression (#3120) ## What it changes `scripts/ui-regression.ts` (CI's required "Browser regression (ui-regression)" job) is red on `main` again: `setChecked` times out after 30 s waiting for `getByRole('switch', { name: 'Suggestion chip' })`. #3108 moved the Suggestion chip switch out of Chat's Composer "More settings" into Claude Code's own settings on the Agents page: in Claude Code's row under "On this PC" when the PC has Claude, else in a "Claude Code" group of its own on that page (and only on a touch screen, which the phone context is). The script still opened `?settings=chat§ion=composer-more`, where the switch no longer is. The step now opens `?settings=agents`, waits for Claude Code's row or its group, opens the row when it is one, and turns the same switch on. The steps and assertions after it are unchanged. I also checked every `scripts/*` file for links, sections and labels of the rows #3108 and #3117 moved or merged (`launch-modes`, `chat-experimental`, the old `voice`/`remote` pages, Permission mode, Artifacts chip, Side conversations chip, Expand thinking, Group agents by state, the two Tidy dictated text switches, the old page names). Apart from this step, #3108 and #3117 had already updated them, so this PR changes only this one script. No product code changes. ## Validation - In `herdr-ci-runner:local` (CI env, a fresh worktree, `bun install --frozen-lockfile`, `bun run build`, `scripts/ci-browser-parallel.ts` with `BROWSER_SCRIPTS=scripts/ui-regression.ts`): - on `origin/main` 309f5b3: FAIL twice, `TimeoutError: setChecked: Timeout 30000ms exceeded` waiting for the `Suggestion chip` switch. - on this branch: PASS (238 s), including "PASS a phone offers Claude's suggestion as a chip once Settings turns it on". - `bun run check fast`: green (unit 12591 pass, 0 fail; typecheck, build, generated files and workflow syntax ok). - Skipped: `ui-contexts-regression`, the integration suite and the other browser scripts (only this step of one script changed).
What
The last step of the Settings simplification. Three pairs of rows become one row each. Every row still reads and writes the same two settings it stood for, so every earlier choice is kept and nothing is removed.
agentGroups), with Within a state right under it; the other two are every browser's order (agentOrder) with the grouping off.showThinking, and this device'sexpandThinking).voicePolishChat,voicePolishTerminal). All four combinations stay possible.Agents order now sits in Appearance's first view, so Group agents by state leaves the More settings fold and its count. Each new row's description says what the two choices mean.
Validation
bun run check faston the pushed head (main with this commit): all green.i18n(the new labels and descriptions placed and translated in ko/ja/zh; the now unused keys gone),settings,paletteSettingsandconventionspass.settings-pages-demo-regression.tswith a newmergedRowsstep. Through a reload it checks: By state shows Within a state and Activity hides it; Expanded and Hidden; and Terminal stores chat off and terminal on.sidebar-split-demo-regression.tsandsidebar-split-access-demo-regression.ts, which now pick By state / Workspaces, by mouse and by keyboard.agent-groups,settings-tabsandchat-size.ui-regression,font-swap,alert-sound,machines-browser-qa,update-browser-qa.relay-shell-browser-qaneeds a real relay.bun run check fulland the rest of the browser lane (CI runs them).Screenshots (demo build)