[devswha]

Part of #2599 (item 2, for the pairing link added after #2759).

Problem

#2759 made RelayService.offer() (POST /api/relay/offer, the QR code) carry the PC's name, so the phone app lists a relay PC under its name instead of its scope URL. The code-less pairing link added later in #2696 (RelayService.pairingLink(), POST /api/relay/link, Copy a link without a code) still builds its offer without name. A phone that pairs from that link saves the PC as https://app.ovis.sh/s/<32 hex>/ again, which is the gap #2599 item 2 describes.

Fix

Both offers take the name from one helper, offerName() in server/relay/service.ts: os.hostname() (the name Ovis lists the PC under, as in server/machines.ts), cut to the 64 characters RelayOffer allows, left out when empty. The name rides in the #offer= fragment, so it never reaches app.ovis.sh or the relay. The link holds no code either way. Its name is no more secret than the one the QR offer already carries.

The code-less link has only shipped in betas (v0.4.23-beta.6), so this PR extends its unreleased Added fragment (changelog.d/relay-pair-by-comparing-digits.md) instead of adding a Fixed line for a feature the next release introduces.

State of the other #2599 items on main (cbcb961)

• Item 1 (open app.ovis.sh/s/ links in the native apps) is still open. It needs an Android App Link (autoVerify intent-filter plus /.well-known/assetlinks.json with the Play signing key's SHA-256) and an iOS Universal Link (Associated Domains plus apple-app-site-association with the Team ID). That takes signing details and an Apple capability change from the maintainer, so this PR does not close the issue.
• Item 3 (file path in the app.ovis.sh page address) was fixed by fix(relay): keep a PC's file paths and panes out of app.ovis.sh requests #2605: readerHref() goes through pageAddress(), which puts the query in the fragment in relay mode.

Validation

• New test names the PC in the pairing link without a code as Ovis lists it (server/relay/service.contract.test.ts) failed on main (Expected: "<hostname>", Received: undefined) and passes with the fix.
• bun test server/relay/service.contract.test.ts server/relay/pair-sas.contract.test.ts server/dispatch.test.ts: 67 pass, 0 fail.
• bun run check fast ran on the code and test change: all steps ok (unit: 11427 pass, 0 fail, 45 skip). The changelog fragment was edited afterwards and checked with bun test scripts/changelog-fold.test.ts (12 pass).
• Skipped: bun run check full, browser and native-app runs. The change is server-side only, in an offer the existing client paths (relayLink() in app/web/shell.js, src/lib/relay/shell.tsx) already read name from.

🤖 Generated with Claude Code

[coderabbitai]

Caution

Review failed

The pull request is closed.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[devswha]

Review: Codex (gpt-6.1-terra, xhigh, read-only) at 110e0ae

MEDIUM: the code-less link now carries the host name, while docs/relay.md said it holds the PC's server_id, public key and relay only. The URL fragment keeps the name from app.ovis.sh and the relay, but not from whatever channel the link is sent through (a messenger, a support ticket).

• Resolved in f583576: docs/relay.md now says both pairing links carry the PC's host name (the QR offer has carried it since fix(relay): name the PC in the relay pairing offer #2759, and that paragraph was out of date too), and that whoever carries the code-less link can read it.
• Left for the maintainer: whether the code-less link should carry the name at all. Native apps: open app.ovis.sh pairing links in the app, name relay PCs, keep file paths out of app.ovis.sh requests #2599 item 2 asks for it in the offer, and the phone's comparison screens (Does {name} show this number?, src/lib/relay/shell.tsx) already read offer.name. A host name can still name a person or an organisation. If it should stay out of a link meant for any channel, the alternative is to drop it from pairingLink() only and keep the phone's generic label for such PCs.

LOW (not changed): a phone that paired from a code-less link before this change keeps its unnamed entry. Opening a newer, named link reuses the saved device record (shared/relay-device.ts), and shared/relay-channel.ts keeps its name. This already applies to PCs paired from a QR offer before #2759. Renaming saved PCs from a later offer is a separate change.

Test note (not changed): on a host whose hostname() is empty, both name tests (the existing QR one and the new one) would expect "" where the offer leaves name out. CI and real hosts have a host name.

CodeRabbit skipped this PR, so this review stands in for it. The review ran at 110e0ae; the only commit since is the docs change f583576.

[devswha]

Merge note

Merged origin/main (1dd4f3fe) into the branch. #2882 (which advertises the regional relay in the code-less pairing link) changed the same line of RelayService.pairingLink(); the conflict was resolved by keeping both sides, so the link now carries relay: this.advertised from main and the PC's name (...offerName()) from this PR, the same fields the QR offer carries. The changelog fragment, docs/relay.md and server/relay/service.contract.test.ts merged without conflicts and read consistently with #2882.

Validation at 27c6407a: bun test server/relay/service.contract.test.ts server/relay/pair-sas.contract.test.ts server/relay/session-ws.contract.test.ts (82 pass, 0 fail) and bun run check fast passed (workflow syntax, generated types and themes, typecheck, build; unit 11660 pass, 0 fail, 46 skip).

CodeRabbit did not review this PR; the Codex review above stands in for it. Its open question for the maintainer is unchanged: whether the code-less link should carry the host name at all (#2599 item 2 asks for it). No review threads are open.

[cloudflare-workers-and-pages]

Deploying ovis with    Cloudflare Pages

Latest commit:	5e54321
Status:	✅  Deploy successful!
Preview URL:	https://5dfc1948.ovis.pages.dev
Branch Preview URL:	https://lane-issue-2599.ovis.pages.dev

View logs

[devswha]

Local merge gate (owner-approved): origin/main merged, bun run check fast passed at this head, review CLEAR at this head (Codex Terra xhigh: no findings), threads resolved, merges cleanly. Merged without waiting for GitHub CI.