Repository navigation
chore: remove the next-agent shortcut and the tool detail copy buttons - #1572
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Summary
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 12 files. (2 skipped:… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title clearly identifies both primary changes: removal of the next-agent shortcut and tool-detail copy buttons. Description check The description follows the required Change and Validation sections. It explains the removed features, retained behavior, changelog handling, and provides detailed test and manual QA results. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 12 functions across 12 files. (2 skipped: 2 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
This was referenced Oct 21, 2026
devswha
added a commit
that referenced
this pull request
Oct 23, 2026
## Change `src/lib/agentRoster.test.ts`'s fixture still set a per-pane `finish_id` and a `finish_epoch` left over from the attention tests #1572 removed; nothing reads them. They are gone, and the test stays, since it is the only coverage of the kept roster order. The issue's second point (the sidebar activity state in `App.tsx`) is only worth doing if profiling shows a cost, and this sweep leaves `App.tsx` alone, so it stays open. Refs #1575 ## Validation - `bun test src/lib/agentRoster.test.ts`: pass. - `bun run check fast`: pass.
devswha
added a commit
that referenced
this pull request
Oct 25, 2026
## Change Selecting text in one of the agent's chat replies drew a **Quote in message** row over the message box (#1845). That row joined the composer stack, so the chat moved under the reader's selection. The maintainer asked for the feature to be removed. Measured on the demo, on main at a1e4f8b: | width | chat scroller height | selected reply's position | | --- | --- | --- | | 1440 | −44 px | unchanged | | 390 (phone) | −84 px | moved 52 px (scrollTop +52) | This PR removes the whole chat-reply feature: - `.composer-quote-row` / `.chat-quote` (PaneTerminal.css) and the row, its press hold and its pointerup listener (PaneTerminal.tsx) - the reply selection tracking and the `.chat-reply` wrapper in ChatView. The page-key line step goes back to `.chat-turn-agent > .markdown`, in ChatView and in `pane-paging-demo-regression.ts`. - ChatTimeline's `holdSelection` row pinning - `formatReplyQuote`, `REPLY_QUOTE_LABEL` and `ComposerDraftStore.appendQuote`, with the tests only they needed - `scripts/reply-quote-demo-regression.ts` and its browser-lane line, the DESIGN.md entry, and the Added fragment The terminal lens keeps its own **Quote in message** (#951) as it was before #1845. #1845 changed only one thing on that path: it moved the fence into a shared `fenceFor` helper, which is now back inline in `formatTerminalQuote`. The terminal still uses its three strings (Quote in message, Added to the message draft, Too long for the message draft), so they stay translated. Files that no later commit touched are restored to their pre-#1845 state; ChatView, PaneTerminal, DESIGN.md and ci-browser.sh were edited by hand, so later work in them is kept. No new design. Chat selection goes back to the plain browser selection and copy that DESIGN.md already describes (the Claude/ChatGPT distinction between selecting text and copying an answer). Changelog: users never got #1845 (`git tag --contains 314200a` is empty). As in #1572, its unreleased Added fragment is deleted and no Removed entry is added. ## Validation - `bun run check fast` (through `dori heavy`): workflow syntax, generated types and themes, typecheck, build, and unit tests (6714 pass) all ok. - No-movement QA on the demo build at 1440 (a real mouse drag) and at 390 phone emulation (a selection range, as a long press leaves it), sampling 40 animation frames after the selection. On this branch the reply's position, the scroller's height and scrollTop, and the message box's position all stay put (deltas 0), no quote row is drawn, and the selection stays. The same script on main shows the movement in the table above. - Terminal lens: `checkTerminalCopyOff` (terminal-copy-off-regression.ts, which drags in the terminal and waits for its Quote in message button) passes on an isolated test herdr. `terminalQuote.test.ts` passes. - Adjacent regressions: `pane-paging-demo-regression.ts`, `chat-selection-copy-regression.ts` and `chat-virtual-browser-qa.ts` pass. `scripts/ci-browser.test.ts` passes. - Reviewed by Codex (gpt-6.1-sol, xhigh): no findings, APPROVE. --------- Co-authored-by: mp <mp@local>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Remove two features added after v0.4.12 because the maintainer judged them unnecessary
during manual QA of main:
action and aliases, its Settings > Shortcuts binding, action-only navigation code,
translations in all three translated locales, documentation, and feature-only tests.
copy-only state and styling, translations, documentation, and feature-only browser test.
Restore the pre-feat(chat): copy raw input and output from tool details #1565 tool detail layout.
Deliberately keep the
agentRoster.tsextraction and App-owned sidebar activity statebecause the sidebar still uses them. Preserve the roster regression test as
agentRoster.test.ts. Keep the existing Output/Error headings, typed tool input,whole-output loading, and message/Markdown copying.
Stored overrides for the removed shortcut are ignored by the existing shortcut-ID
allowlist. Existing settings tests already cover unknown stored IDs, so no duplicate
test or storage migration is needed.
Neither
git tag --contains 626204fanorgit tag --contains 0cd899f7lists a tag(both exit 0). Delete both unreleased changelog fragments rather than adding a
Removed entry. No new UI design is introduced; the tool detail returns to its existing
pre-#1565 design.
Validation
bun run check fast: exit 0; 5,810 passed, 0 failed, 8 skipped.Generated types/themes, workflow syntax, typechecks, build, and unit tests passed.
bun test src/lib/shortcuts.test.ts src/lib/settings.test.ts src/lib/agentRoster.test.ts src/lib/sidebarOrder.test.ts src/lib/sidebarActivity.test.ts scripts/ci-browser.test.ts scripts/pages-gate.test.tsbun test scripts/ci-browser.test.ts scripts/pages-gate.test.tsbun scripts/sidebar-activity-demo-regression.ts: exit 0.bun scripts/shortcut-exact-modifiers-demo-regression.ts: exit 0.Both used a fresh shared demo build and isolated fictional fixtures.
and dark: no tool-detail copy controls; Output/Error and whole-output loading remain;
removed palette action and shortcut setting are absent; old saved/default chords do
not navigate; the existing palette and Settings shortcuts still work.
git diff --check: exit 0.inspected all 12 desktop/phone, light/dark screenshots. Its only initial finding
was a dead reference to the removed browser script in the parallel runner; that
reference is removed.
The Omo reviewer could not start because this session reached its nesting limit.
All checks used isolated fixtures, not the maintainer's live herdr session.