[devswha]

Change

src/lib/agentRoster.test.ts's fixture still set a per-pane finish_id and a finish_epoch left over from the attention tests #1572 removed; nothing reads them. They are gone, and the test stays, since it is the only coverage of the kept roster order.

The issue's second point (the sidebar activity state in App.tsx) is only worth doing if profiling shows a cost, and this sweep leaves App.tsx alone, so it stays open.

Refs #1575

Validation

• bun test src/lib/agentRoster.test.ts: pass.
• bun run check fast: pass.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: devswha/ovis
• Branch: test/agent-roster-fixture
• File: .coderabbit.yaml
• Commit: f1e973e
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: bfc3973a-7f2f-4b16-a856-729edf5e3663

📥 Commits

Reviewing files that changed from the base of the PR and between 464fda5 and f1e973e.

📒 Files selected for processing: 1

• src/lib/agentRoster.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

📝 Summary

Summary by CodeRabbit

• Tests
  • Updated test coverage to reflect the current agent and pane status information. These changes affect only internal validation; no user-facing features or behavior have changed.

The agent roster test helper and its local and remote fixtures no longer include pane finish IDs or snapshot finish epochs.

Changes: Agent roster test

Layer / File(s)	Summary
Update machine fixtures src/lib/agentRoster.test.ts	The helper and local and remote fixtures no longer include finish IDs or finish epochs. They continue to define pane IDs and agent statuses.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related issues

• devswha/herdr-web-ui#1575: This change removes the unused finish_id and finish_epoch fixture fields requested by the issue.

Merge Risk: ⚪ Minimal · up to f1e97

This test-fixture cleanup does not change production behavior, and the reported checks pass.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly identifies the test fixture change and the removal of unused finish IDs.
Description check		The description includes the Change and Validation sections. It explains the removed fixture fields, retained test coverage, out-of-scope App.tsx work, issue reference, and validation results.
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}