Skip to content

Network giveup - #186

Closed
rawdigits wants to merge 12 commits into
commaai:develfrom
rawdigits:network_giveup
Closed

rawdigits wants to merge 12 commits into
commaai:develfrom
rawdigits:network_giveup

Conversation

@rawdigits

Copy link
Copy Markdown

Adds a counter to the loop and gives up if ping fails 30 times. I would have done time math, but the device may update its time/etc and I didn't want to depend on system time for this.

@gregjhogan

Copy link
Copy Markdown
Contributor

I think when it gets to the NEOS update check it will still hang forever if there is an update (and you don't have a network connection). Maybe you need to make it a little smarter?

@rawdigits

Copy link
Copy Markdown
Author

Ah I see your point. If this tree is updated, the reboot may trigger the neos check because /VERSION may require something higher than 4. Meh - this whole thing needs to be refactored, tbh.

@geohot

geohot commented Mar 19, 2018

Copy link
Copy Markdown
Contributor

Fixed in new version

@geohot geohot closed this Mar 19, 2018
mlocoteta pushed a commit to mlocoteta/openpilot that referenced this pull request Jul 17, 2023
* Toyota longitudinal: TSS2 custom tuning behind toggle

* cleanup

* add param

* Update CHANGELOGS.md

* Update CHANGELOGS.md
nworb-cire pushed a commit to opgm/openpilot that referenced this pull request Aug 2, 2024
nworb-cire pushed a commit to opgm/openpilot that referenced this pull request Aug 2, 2024
0312birdzhang pushed a commit to 0312birdzhang/openpilot that referenced this pull request Jul 30, 2025
* TR14L model..

* fix.. long
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants