openpilot 0.3.4 by espes · Pull Request #120 · commaai/openpilot

espes · 2017-07-28T10:38:49Z

This is the space for public comment before we merge into release.

Release

Update alert text

Pulled in new panda firmware and updated boardd to support the changes.

…e changes."

Revert "Pulled in new panda firmware and updated boardd to support the changes."

zax123 · 2017-07-28T12:20:08Z

I was thinking that in:

selfdrive/can/process_dbc.py (v0.3.4)

the line 27:

checksum_type = "honda" if can_dbc.name.startswith("honda") or can_dbc.name.startswith("acura") else None

Should probably be in the selfdrive/car/ structure somehow? Or maybe in fingerprints.py? In the spirit of keeping car abstractions isolated to selfdrive/car/ and fingerprints.py...

geohot · 2017-07-28T18:13:08Z

  struct CruiseState {
    enabled @0: Bool;
    speed @1: Float32;
+    mainOn @2: Bool;


I'm not sure this belongs here? What does this mean in general for cruise control systems?

@geohot , I've been thinking about where to put this indeed. It belongs either here or in the parent structure CarState. When Main is off, pcm cruise can't be engaged. Main is a latching state that is sent on CAN by the steering control module; it can be altered by pressing the "Main" button on the steering wheel.

geohot · 2017-07-28T18:19:09Z

+  if os.getenv("PREPAREONLY") is not None:
+    spinner_proc = None
+  else:
+    spinner_proc = subprocess.Popen(["./spinner", "loading openpilot..."],


Don't use ./, use BASEDIR to get an absolute path

. is relative to cwd which is set from BASEDIR on the next line.

geohot · 2017-07-28T18:19:46Z

 import numpy as np
+
 from selfdrive.car.honda.can_parser import CANParser
+from selfdrive.can.parser import CANParser as CANParserC


Does this import work in openpilot?

Oh never mind, I see it. Why hasn't old can been deleted?

The openpilot tests still relies on it. Will be removed when the openpilot tests are replaced.

geohot · 2017-07-28T18:20:14Z

@@ -0,0 +1 @@
+sensord


We have this ignored, yet we ship it also?

geohot · 2017-07-28T18:20:59Z

@@ -0,0 +1,77 @@
+#include <stdio.h>


Why are we shipping the spinner binary? (didn't know how to comment on the binary itself)

The spinner is launched while openpilot native components are being compiled. It'll be moved to NEOS in the next NEOS release.

geohot · 2017-07-28T18:21:42Z

  const UIScene *scene = &s->scene;

+  // dont draw alerts that are outdated by > 20 secs
+  if ((nanos_since_boot() - scene->alert_ts) >= 20000000000ULL) {


Why is this ever happening in the first place?

When controlsd exists with an alert active. Alerts should eventually be refactored to be managed by ui instead of controls.

geohot · 2017-07-28T18:34:49Z

@zax123 It really should be added as a semantic comment in the DBC file. Like next to the checksum. We should also put the rate at which we expect the message in there.

geohot · 2017-07-28T18:37:45Z

+    libdbc.can_update(self.can, sec, wait)
+    return self.update_vl(sec)
+
+if __name__ == "__main__":


We should really refactor this into a test.

TheMutley · 2017-07-28T23:24:18Z

@geohot you can use the following attribute to specify the cycle time

Define the attribute:
BA_DEF_ BO_ "GenMsgCycleTime" INT 0 3600000;

Define the default value
BA_DEF_DEF_ "GenMsgCycleTimeFast" 0;

Set for a message 223 (int)
BA_ "GenMsgCycleTime" BO_ 223 100;

There's also many more standard attribute that are available, let me know which one you would need and I will add them to the DBCs

TheMutley · 2017-07-28T23:49:36Z

@espes could you also add the left/right blind spot in the car abstraction ?

espes · 2017-07-29T04:55:23Z

@TheMutley Open an issue or pull request for what you'd like RE blind spot detectors.

3f6cd74 Add 3rd RSA signal and cleanup (#120) a308ec1 add vals honda (#121) 1317514 Toyota: fixed typos 0339fc8 Toyota: added a better cruise active indicator b0c012d Lexus: add is 94ba43c Toyota: generated dnc files after latest change e16723e Add Distance Lines and RSA (#118) 9aec1ef Add GM signals for ESP/Mode/Highbeams/Intellibeam (#114) a67fff9 add toyota_prius_2010_pt.dbc (#50) c1ee10f Revert "Revert "GM: copy radar header from cadillac (#116)"" git-subtree-dir: opendbc git-subtree-split: 3f6cd74

No braking with set speed if blinker is on

* Add 3rd RSA signal and cleanup Moved order of messages to be ascending. Added 3rd can message from RSA and added value for the no overtake sign. * Add more comments * More comments * Add better explaination * Add 1163 Comments * SPDVAL1 checked and comment corrected * TSGN3 Signs * generate new files with rsa

* fix ALCA module * Update ALCA_module.py * Promote panda fixes from alpha to devel (commaai#98) * Fix for mock car crash * fix ALCA module * do not use * radar_interface logic improvements * remove radar logging * radar_interface refactoring * Log radar_interface CAN error, Process Comm Errors (commaai#95) * Log radar_interface CAN error * Add support for process comm error logging * Improve Process Comm error logging * Can and CommError throttling * Update radar_interface.py * fixing push per Raf's comments * ALCA and radar_interface work (commaai#96) (commaai#97) * do not use * radar_interface logic improvements * remove radar logging * radar_interface refactoring * Update radar_interface.py * fixing push per Raf's comments * fix process comm issue * switch radard from lane_parser to model * radar/ALCA changes * fix lane width * switched back to not deleting CarParams to avoid radar failure when rebooting EON while driving * cleanup some debug info to be able to restart ALCA research * tweaks on safety_tesla.h for can bus isolation * few more cleanups to safety_tesla.h * fix start signal logic * Increase LEXUS_IS safetyParam to 77 (commaai#841) * use list comprehension (commaai#839) * use list comprehension * oops index range fix * simplify encode/decode in dbc (commaai#840) * simplify encode/decode * 2019 Highlander Hybrid Limited Platinum (commaai#843) fingerprint from ogdragonzypher on Discord * Allow to lock safety mode to keep gm/tesla cars supported (commaai#844) * Force subaru to assume the stock camera is connected (commaai#849) * Revert to using the sum of the lane line probabilities instead of the the product * Add core OP support for CRC validation, with extra support for Volkswagen MQB (commaai#836) * Generalized core OP CRC support plus extra bits for Volkswagen MQB. * Update ref to process_replay regression test * Remove unneded use of replace, causing json to fail loading the alert * Add supported car for 2019 Toyota Altis Hybrid (commaai#859) * add supported car for 2019 Toyota Altis Hybird / Corolla hybrid 2020 (US market) * remove unnecessary comprehensions (commaai#863) * Added fingerprint from Sienna XLE AWD (commaai#848) * Added fingerprint from Sienna XLE AWD * Update driver_monitor.py * Update driver_monitor.py * Update driver_monitor.py * fix stupid merge issue * Adds 2019 Lexus ES (non hybrid) (commaai#866) * Adds 2019 Lexus ES (non hybrid) * Updated test route * merge issues * Update README with now supported Subaru Harness * Disable LDW for 4 seconds after blinker transition from on to off (commaai#112) If we want to change lanes with a blinker tap (3 blink mode), then we need to disable LDW for enough time to allow a smooth manual lane change. 4 seconds as it seems the freq is actually around 50Hz, not 100Hz. * Disable HSO for 3 seconds after blinker has been active (commaai#111) Avoid HSO will deactivate and try to take the car back into the lane during a manual lane change with blinker tapped (3 blinks mode) * params learner to only learn @ cons speed Acceleration/deceleration in turns affect yaw as measured by phone and will create potential issues with learner. This code changes the learner to only adjust parameters when speed is constant * Update to match new version of python in eons * python 3 fixes for test client / server * async/await server * Don't log for action message as it's too often, and we throttle it internally. * fix merge issue in thermald * fixes and tweaks; code simplification * Saving P,I,F parameters from pid controller (commaai#116) Added separate save/load functions, try catch - and saving the right constants to the params file. * Feature/tinklad throttling + linting (commaai#118) * Throttle tinlkad's attemptToSendPendingMessages * Remove get_git_remote from registration. It's defined in version already. * tinklad linting * tesla linting * Prevent multiple readings of the pid params file (commaai#119) ..only load the pid values when we initiate the LoC * missing V_PID_FILE constant (commaai#121) * show cars in IC for non-radar users (commaai#120) * bug fixes * Fix issue where user info was being dropped on no connectivity (commaai#122) * move pisParams, fix GPS logging * Bugfix tinklad throttling (commaai#124) * ALCA4 (still in dev) * ALCA4 tuning * ALCA4 alpha release * ALCA4 tweak for turns * ACC fix; LDW mite during ALCA * ALCA polishing * fix enter_canloader.py for python 3 * should_ldw changes moved the should_ldw code closer together and added status messages for when LDW is active and inactive * thermald and ALCA * ALCA sinplified logic

) * cleaner * ui: CPU temperature on sidebar: rate limit to refresh every second

3f6cd74 Add 3rd RSA signal and cleanup (commaai#120) a308ec1 add vals honda (commaai#121) 1317514 Toyota: fixed typos 0339fc8 Toyota: added a better cruise active indicator b0c012d Lexus: add is 94ba43c Toyota: generated dnc files after latest change e16723e Add Distance Lines and RSA (commaai#118) 9aec1ef Add GM signals for ESP/Mode/Highbeams/Intellibeam (commaai#114) a67fff9 add toyota_prius_2010_pt.dbc (commaai#50) c1ee10f Revert "Revert "GM: copy radar header from cadillac (commaai#116)"" git-subtree-dir: opendbc git-subtree-split: 3f6cd74 old-commit-hash: 2f0b0fb

pjlao307 and others added 10 commits July 3, 2017 11:15

Merge pull request #2 from commaai/release

721ed4e

Release

Update steering controls saturated message

2aa9a56

Merge pull request #113 from pjlao307/update-alert-text

e4aa959

Update alert text

Pulled in new panda firmware and updated boardd to support the changes.

9a9dc3a

Moved boardd loopback config to envvar.

38aa03e

Removed unnecessary TODO

5bf4196

Merge pull request #114 from diamondman/new_panda_code

317ae0f

Pulled in new panda firmware and updated boardd to support the changes.

Revert "Pulled in new panda firmware and updated boardd to support th…

1581fdc

…e changes."

Merge pull request #116 from commaai/revert-114-new_panda_code

68485aa

Revert "Pulled in new panda firmware and updated boardd to support the changes."

openpilot v0.3.4 release

6f46f98

espes changed the title ~~openpilot 0.3.3~~ openpilot 0.3.4 Jul 28, 2017

geohot reviewed Jul 28, 2017

View reviewed changes

openpilot v0.3.4 tweaks

1b8c44b

espes merged commit 0fba33b into release Jul 29, 2017

mespiritu pushed a commit to mespiritu/openpilot that referenced this pull request Apr 1, 2019

Merge pull request commaai#120 from arne182/release2

323cccc

No braking with set speed if blinker is on

rafcabezas pushed a commit to rafcabezas/openpilot that referenced this pull request Nov 7, 2019

show cars in IC for non-radar users (commaai#120)

edb6a48

nworb-cire referenced this pull request in opgm/openpilot Aug 2, 2024

ui: CPU temperature on sidebar: rate limit to refresh every second (#120

b341c81

) * cleaner * ui: CPU temperature on sidebar: rate limit to refresh every second

		@@ -0,0 +1 @@
		sensord

Uh oh!

Conversation

espes commented Jul 28, 2017

Uh oh!

zax123 commented Jul 28, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

geohot Jul 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

geohot Jul 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

geohot Jul 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

geohot commented Jul 28, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TheMutley commented Jul 28, 2017

Uh oh!

TheMutley commented Jul 28, 2017

Uh oh!

espes commented Jul 29, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

geohot Jul 28, 2017 •

edited

Loading

geohot Jul 28, 2017 •

edited

Loading

geohot Jul 28, 2017 •

edited

Loading