Let solargraph-rails spec failures fail CI again - #1321
Open
apiology wants to merge 3 commits into
Open
Conversation
The "Run specs" step of run_solargraph_rails_specs has carried continue-on-error since castwide#1200, with a @todo naming 0.60 as the point to revert it. Solargraph is at 0.60.3 and solargraph-rails at 436763d passes that suite against this branch: 43 examples, 0 failures, 4 pending.
apiology
added a commit
to apiology/solargraph
that referenced
this pull request
Aug 20, 2026
…ls fix branch Takes the solargraph-rails Array#sum decision off the critical path. The plugin jobs clone and bundle solargraph-rails from drop-array-sum-annotation instead of main, so the two Unresolved call to items findings at complex_type/type_methods.rb:219 stop blocking this branch. Measured on #62 - rails and regression go from 4 problems to 2. The solargraph-rails fix itself: iftheshoefritz/solargraph-rails#211 Temporary. Once enough has merged to solargraph-rails main this reverts, and castwide#1321 is what should fail if the fix has not landed there. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015AsvDi68YqsKoBtS2kg9ch
apiology
marked this pull request as ready for review
August 24, 2026 21:02
apiology
marked this pull request as draft
August 31, 2026 17:15
The run_solargraph_rails_specs job clones solargraph-rails main unpinned, so its result changes without any commit here. The last run was 2026-08-31 and failed on 15 examples. Re-run it against whatever that repo is today.
apiology
changed the title
apiology
marked this pull request as ready for review
September 6, 2026 00:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude:
A solargraph-rails regression caught by
run_solargraph_rails_specsis still reported as a green check: the step has carriedcontinue-on-error: truesince #1200, whose@todonamed 0.60 as the revert point. Solargraph is now at 0.60.4.This removes the stub from that one step; the others #1200 added are untouched.
This PR was written by Claude Code on behalf of @apiology.