Demo only: show the solargraph-rails Array#sum fix in plugin CI - #62
Merged
Merged
Conversation
Not for merge. Pins solargraph-rails to a third-party branch so the rails and regression jobs typecheck against iftheshoefritz/solargraph-rails#211 instead of the released gem. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude:
Do not merge
This branch exists only to produce CI logs. It pins
solargraph-railsto a branch in a third-party repository (iftheshoefritz/solargraph-rails@drop-array-sum-annotation), which will be deleted once iftheshoefritz/solargraph-rails#211 merges — at which point every job here breaks. Close it once the logs have been read.What it demonstrates
iftheshoefritz/solargraph-rails#211 deletes
def sum; endfrom the plugin'slib/solargraph/rails/annotations/array.rb. That stub contributes an arity-0, blockless() -> untypedoverload to the combinedArray#sumpin, alongside core rbs's(?untyped init) ?{ (E e) -> untyped } -> untyped. When the blockless overload wins, the block parameter inkey_types.sum { |t| t.items.length }loses its element type.Expected outcome
The
railsandregressionjobs should drop from 4 problems to 2, losing both of:and keeping both
Unneeded @sg-ignore commentresults.Note on the diff
The
railsandregressionjobs installsolargraph-railsfrom RubyGems via.Gemfile, not from thegit cloneinrun_solargraph_rails_specs. Changing only the clone target would have left those two jobs on the released gem, so the two.Gemfilelines are pinned to the branch as well. The clone target is changed too, sorun_solargraph_rails_specsexercises the same branch.This PR was written by Claude Code on behalf of @apiology.