Temporary job stubs - #1200
Merged
Merged
Conversation
castwide
force-pushed
the
temp-continue-on-error
branch
from
May 20, 2026 00:57
37e8aea to
606809c
Compare
apiology
added a commit
to apiology/solargraph
that referenced
this pull request
Aug 18, 2026
The `regression`, `rails` and `rspec` jobs in plugins.yml each run `solargraph typecheck --level strong` against this repo with a plugin loaded, to catch a plugin breaking typechecking. All three carried `continue-on-error: true` from 09be4a6 (castwide#1200), so all three reported success while exiting 1. They were exiting 1 for the same reason typecheck.yml was: at 8fda633 each reported "525 problems found in 90 of 250 files", the identical count typecheck.yml reported. The annotations in this PR resolve them. On this branch at 38abf73 all three report "0 problems found in 0 of 250 files": regression https://github.com/castwide/solargraph/actions/runs/31549739327/job/93969644932 rails https://github.com/castwide/solargraph/actions/runs/31549739327/job/93969644920 rspec https://github.com/castwide/solargraph/actions/runs/31549739327/job/93969644939 Removing the flags here rather than in a follow-up keeps the fix and the gates it restores in one change. Left alone: run_solargraph_rails_specs, whose flag masks 18 failures in iftheshoefritz/solargraph-rails and which no annotation here touches. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CXmnT5gSB1PheL9UbiGEVA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few of the checks have gotten especially noisy while the codebase is in flux. I'm temporarily setting
continue-on-erroron the jobs and hope to get them sorted by version 0.60.