Make rbs validate a blocking CI check again - #1317
Open
apiology wants to merge 2 commits into
Open
Conversation
`bundle exec rbs validate` was masked with `continue-on-error: true` in 09be4a6 (castwide#1200) along with seven other steps, marked "expect to revert in 0.60". 0.60.0 through 0.60.3 have shipped. The step passes on every run sampled: the master push at 8fda633 and five recent pull-request runs. Nothing is being suppressed, so the flag only hides the verdict of a check that already reports accurately. The other steps from that commit still exit non-zero and are left alone. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CXmnT5gSB1PheL9UbiGEVA
apiology
added a commit
to apiology/solargraph
that referenced
this pull request
Aug 19, 2026
apiology
marked this pull request as ready for review
August 24, 2026 22:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rbs validatein the Linting workflow carriescontinue-on-error: truefrom #1200, marked# @todo Temporary, expect to revert in 0.60. 0.60 has since shipped through 0.60.3.Unlike the other steps stubbed in that commit, this one passes — on master and on every recent PR run sampled, none of which contain
Process completed with exit code. So removing the flag suppresses nothing and changes no outcome today; it only lets the check report what it finds from here on.Out of scope: the
solargraph typecheck --level strongflag is handled by #1240, the tworubocop_todoflags by #1260. The rest still exit non-zero and each needs its own fix.This PR was written by Claude Code on behalf of @apiology.