[Merged by Bors] - Optimize Iterator::count for event iterators - #7582
Closed
joseph-gio wants to merge 1 commit into
Closed
[Merged by Bors] - Optimize Iterator::count for event iterators#7582joseph-gio wants to merge 1 commit into
Iterator::count for event iterators#7582joseph-gio wants to merge 1 commit into
Conversation
joseph-gio
added
A-ECS
alice-i-cecile
approved these changes
Feb 9, 2023
alice-i-cecile
added
the
S-Ready-For-Final-Review
Member
|
Those iterators also implement |
Member
Author
What do you mean by this? |
Member
|
the doc for the trait methods is https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.count which specifically mention calling all the |
Member
Author
|
Correct me if I'm wrong, but there is no observable difference between repeatedly calling |
alice-i-cecile
removed
the
S-Ready-For-Final-Review
Member
You're right. Let's hope no one rely on something being not the most efficient 😄 |
alice-i-cecile
added
the
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Feb 13, 2023
bors Bot
pushed a commit
that referenced
this pull request
Feb 13, 2023
# Objective Related to #7530. `EventReader` iterators currently use the default impl for `.count()`, which unnecessarily loops over all unread events. # Solution Add specialized impls that mark the `EventReader` as consumed and return the number of unread events.
|
Pull request successfully merged into main. Build succeeded:
|
bors
Bot
changed the title
Iterator::count for event iteratorsIterator::count for event iterators
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 14, 2023
# Objective Related to bevyengine#7530. `EventReader` iterators currently use the default impl for `.count()`, which unnecessarily loops over all unread events. # Solution Add specialized impls that mark the `EventReader` as consumed and return the number of unread events.
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 15, 2023
# Objective Related to bevyengine#7530. `EventReader` iterators currently use the default impl for `.count()`, which unnecessarily loops over all unread events. # Solution Add specialized impls that mark the `EventReader` as consumed and return the number of unread events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Related to #7530.
EventReaderiterators currently use the default impl for.count(), which unnecessarily loops over all unread events.Solution
Add specialized impls that mark the
EventReaderas consumed and return the number of unread events.