[Merged by Bors] - Optimize .nth() and .last() for event iterators - #7530
Closed
joseph-gio wants to merge 9 commits into
Closed
[Merged by Bors] - Optimize .nth() and .last() for event iterators#7530joseph-gio wants to merge 9 commits into
.nth() and .last() for event iterators#7530joseph-gio wants to merge 9 commits into
Conversation
alice-i-cecile
added
A-ECS
joseph-gio
marked this pull request as ready for review
February 7, 2023 13:30
ciro-c
approved these changes
Feb 7, 2023
tim-blackbird
approved these changes
Feb 7, 2023
bors Bot
pushed a commit
that referenced
this pull request
Feb 13, 2023
# Objective Related to #7530. `EventReader` iterators currently use the default impl for `.count()`, which unnecessarily loops over all unread events. # Solution Add specialized impls that mark the `EventReader` as consumed and return the number of unread events.
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 14, 2023
# Objective Related to bevyengine#7530. `EventReader` iterators currently use the default impl for `.count()`, which unnecessarily loops over all unread events. # Solution Add specialized impls that mark the `EventReader` as consumed and return the number of unread events.
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 15, 2023
# Objective Related to bevyengine#7530. `EventReader` iterators currently use the default impl for `.count()`, which unnecessarily loops over all unread events. # Solution Add specialized impls that mark the `EventReader` as consumed and return the number of unread events.
james7132
approved these changes
Feb 16, 2023
james7132
left a comment
james7132
left a comment
Member
There was a problem hiding this comment.
Took longer to look into this. Wanted to make sure the overridden implementation on Chain and slice's iterators were optimized as mentioned in the PR description. LGTM.
james7132
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
Feb 16, 2023
Member
|
bors r+ |
bors Bot
pushed a commit
that referenced
this pull request
Feb 16, 2023
# Objective Motivated by #7469. `EventReader` iterators use the default implementations for `.nth()` and `.last()`, which includes iterating over and throwing out all events before the desired one. ## Solution Add specialized implementations for these methods that directly updates the unread event counter and returns a reference to the desired event. TODO: - [x] Add a unit test. - [x] ~~Add a benchmark, to see if the compiler was doing this automatically already.~~ *On second thought, this doesn't feel like a very useful thing to include in the benchmark suite.*
bors
Bot
changed the title
.nth() and .last() for event iterators.nth() and .last() for event iterators
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 18, 2023
# Objective Motivated by bevyengine#7469. `EventReader` iterators use the default implementations for `.nth()` and `.last()`, which includes iterating over and throwing out all events before the desired one. ## Solution Add specialized implementations for these methods that directly updates the unread event counter and returns a reference to the desired event. TODO: - [x] Add a unit test. - [x] ~~Add a benchmark, to see if the compiler was doing this automatically already.~~ *On second thought, this doesn't feel like a very useful thing to include in the benchmark suite.*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Motivated by #7469.
EventReaderiterators use the default implementations for.nth()and.last(), which includes iterating over and throwing out all events before the desired one.Solution
Add specialized implementations for these methods that directly updates the unread event counter and returns a reference to the desired event.
TODO:
Add a benchmark, to see if the compiler was doing this automatically already.On second thought, this doesn't feel like a very useful thing to include in the benchmark suite.