Fix Component macro hook composition codegen#24039
Merged
Merged
Conversation
alice-i-cecile
left a comment
alice-i-cecile
left a comment
Member
There was a problem hiding this comment.
Reasonable fix; thanks for the regression test!
alice-i-cecile
approved these changes
Apr 29, 2026
SpecificProtagonist
approved these changes
Apr 29, 2026
alice-i-cecile
added
C-Bug
tychedelia
pushed a commit
to processing/bevy
that referenced
this pull request
Apr 30, 2026
# Objective bevyengine#24000 introduced the ability to use both relationships and user-provided hooks with `#[derive(Component)]`, but the hook function that is generated when there's a conflict does not compile. ## Solution Remove an errant nested `quote!`, and change the inline function definition to a closure so that `Self` type references work. ## Testing Updated the test to check the rest of the hooks, and it passes with this fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
#24000 introduced the ability to use both relationships and user-provided hooks with
#[derive(Component)], but the hook function that is generated when there's a conflict does not compile.Solution
Remove an errant nested
quote!, and change the inline function definition to a closure so thatSelftype references work.Testing
Updated the test to check the rest of the hooks, and it passes with this fix.