Allow all hooks on relationship components#24000
Merged
alice-i-cecile merged 3 commits intoApr 28, 2026
Merged
Conversation
SpecificProtagonist
added
C-Feature
SkiFire13
reviewed
Apr 27, 2026
| struct RelTarget(Entity); | ||
|
|
||
| fn on_add(world: DeferredWorld, context: HookContext) { | ||
| assert!(!world.entity(context.entity).contains::<RelTarget>()); |
Contributor
There was a problem hiding this comment.
I think this is a point of discussion: do we want the user defined hook to run before or after the relationship one?
Contributor
Author
There was a problem hiding this comment.
I think it doesn't matter a lot because structural changes are deferred. Currently the order in which hooks are called when inserting/removing multiple components at once isn't specified either (and they all run before the world is flushed).
I suppose this assert is misleading in this regard as it's independent of the order.
chescock
approved these changes
Apr 27, 2026
chescock
left a comment
chescock
left a comment
Contributor
There was a problem hiding this comment.
Oh, nice, you managed to get this down to a pretty small change!
alice-i-cecile
approved these changes
Apr 28, 2026
alice-i-cecile
left a comment
alice-i-cecile
left a comment
Member
There was a problem hiding this comment.
Wow, that's incredibly nice. Love to see it!
alice-i-cecile
added
S-Ready-For-Final-Review
tychedelia
pushed a commit
to processing/bevy
that referenced
this pull request
Apr 30, 2026
# Objective Fixes bevyengine#23990 ## Solution If both the user and the relationship define a hook, call both. ## Testing Added a test checking hooks don't interfere with relationships. --- ## Showcase ```rust #[derive(Component)] #[relationship(relationship_target = LikedBy)] #[component(on_add = on_add)] struct Likes(Entity); ```
tychedelia
pushed a commit
to processing/bevy
that referenced
this pull request
Apr 30, 2026
# Objective bevyengine#24000 introduced the ability to use both relationships and user-provided hooks with `#[derive(Component)]`, but the hook function that is generated when there's a conflict does not compile. ## Solution Remove an errant nested `quote!`, and change the inline function definition to a closure so that `Self` type references work. ## Testing Updated the test to check the rest of the hooks, and it passes with this fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #23990
Solution
If both the user and the relationship define a hook, call both.
Testing
Added a test checking hooks don't interfere with relationships.
Showcase