Fix solari GI shadow regression#21919
Merged
Merged
Conversation
JMS55
added
A-Rendering
JMS55
added
the
S-Needs-Review
IceSentry
approved these changes
Nov 26, 2025
JMS55
added
S-Ready-For-Final-Review
SparkyPotato
approved these changes
Nov 27, 2025
james7132
approved these changes
Nov 29, 2025
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Dec 30, 2025
Same series of changes to resampling we did for DI, but now applied to GI. Effectively reverts #21919. The piece I was missing before was that I was applying the visibility test to the reservoir's radiance, and not the UCW, which was wrong.
mockersf
pushed a commit
that referenced
this pull request
Dec 30, 2025
Same series of changes to resampling we did for DI, but now applied to GI. Effectively reverts #21919. The piece I was missing before was that I was applying the visibility test to the reservoir's radiance, and not the UCW, which was wrong.
mockersf
pushed a commit
that referenced
this pull request
Dec 30, 2025
Same series of changes to resampling we did for DI, but now applied to GI. Effectively reverts #21919. The piece I was missing before was that I was applying the visibility test to the reservoir's radiance, and not the UCW, which was wrong.
mockersf
pushed a commit
that referenced
this pull request
Dec 30, 2025
Same series of changes to resampling we did for DI, but now applied to GI. Effectively reverts #21919. The piece I was missing before was that I was applying the visibility test to the reservoir's radiance, and not the UCW, which was wrong.
mockersf
pushed a commit
that referenced
this pull request
Dec 30, 2025
Same series of changes to resampling we did for DI, but now applied to GI. Effectively reverts #21919. The piece I was missing before was that I was applying the visibility test to the reservoir's radiance, and not the UCW, which was wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #21649, I switched where visibility rays get traced, and while it improved DI, it regressed GI. I'm reverting the GI change to fix.
Before:
After:
