Core menus and Popover#19983
Closed
viridia wants to merge 3 commits into
Closed
Conversation
alice-i-cecile
added
C-Feature
Member
|
Per our discussion, this is blocked on better templates. |
Contributor
|
Needs #20064 |
favilo
reviewed
Jul 21, 2025
| /// Close the entire menu stack. The boolean argument indicates whether we want to retain | ||
| /// focus on the menu owner (the menu button). Whether this is true will depend on the reason | ||
| /// for closing: a click on the background should not restore focus to the button. | ||
| CloseAll(bool), |
There was a problem hiding this comment.
Sorry for the drive by. But this bool behavior isn't obvious to me. Could we replace it with an enum with two variants that work out the behavior explicitly?
pub enum {
FocusReturnToOwner,
FocusDefaultEntity, // or whatever name/behavior would work here
}
Contributor
Author
There was a problem hiding this comment.
My latest version of this gets rid of it entirely.
Contributor
Author
|
Closing in favor of #21636 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
This is a draft PR for the "core menu" and "popover" components.
Part of #19236