Fix "dark grey" colors becoming lighter in various examples#12333
Merged
Conversation
mockersf
approved these changes
Mar 6, 2024
TrialDragon
approved these changes
Mar 6, 2024
mockersf
added
the
S-Ready-For-Final-Review
spectria-limina
pushed a commit
to spectria-limina/bevy
that referenced
this pull request
Mar 9, 2024
…ne#12333) # Objective Fixes bevyengine#12226 Prior to the `bevy_color` port, `DARK GRAY` used to mean "dark grey." But it is now lighter than `GRAY`, matching the css4 spec. ## Solution Change usages of `css::DARK_GRAY` to `Color::srgb(0.25, 0.25, 0.25)` to restore the examples to their former colors. With one exception: `display_and_visibility`. I think the new color is an improvement. ## Note A lot of these examples could use nicer colors. I'm not trying to revamp everything here. The css4 palette is truly a horror. See bevyengine#12176 and bevyengine#12080 for some discussion about alternatives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #12226
Prior to the
bevy_colorport,DARK GRAYused to mean "dark grey." But it is now lighter thanGRAY, matching the css4 spec.Solution
Change usages of
css::DARK_GRAYtoColor::srgb(0.25, 0.25, 0.25)to restore the examples to their former colors.With one exception:
display_and_visibility. I think the new color is an improvement.Note
A lot of these examples could use nicer colors. I'm not trying to revamp everything here.
The css4 palette is truly a horror. See #12176 and #12080 for some discussion about alternatives.