0.14 migration: Slightly more help for users who had their colors changed#1392
Merged
Merged
Conversation
rparrett
added
C-Feature
alice-i-cecile
approved these changes
Jun 12, 2024
rparrett
changed the title
BD103
approved these changes
Jun 12, 2024
BD103
left a comment
BD103
left a comment
Member
There was a problem hiding this comment.
Like this change, thank you! I have one nit about capitalizing CSS, but the rest is good!
BD103
added
the
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are simple changes to migrate, but we are asking users to do a lot of research and could be helping them out a bit more.
I think these three colors were the extent of the damage for "color values getting changed," though maybe we could also throw "colors that simply had their names changed" into the table as well.
Do we have a handy list of those? I thought they were listed in some iteration of the migration guide previously.
For reference:
bevyengine/bevy#12451
bevyengine/bevy#12333
bevyengine/bevy#12328