Repository navigation
Test external CryptoProvider integration through public S3 APIs - #873
Draft
RanaPriyansh wants to merge 1 commit into
Draft
RanaPriyansh wants to merge 1 commit into
RanaPriyansh wants to merge 1 commit into
Conversation
Contributor
|
You have many PRs open: https://github.com/apache/arrow-rs-object-store/pulls?q=is%3Apr+state%3Aopen+author%3ARanaPriyansh Which one do you think is the most imporant to review first? |
Contributor
|
Marking as draft per #873 (comment) so i can find the PRs that need attention. Thank you |
alamb
marked this pull request as draft
October 16, 2026 21:20
This was referenced Oct 16, 2026
Author
|
Please review #861 first. It fixes the GCS upload credential fetch reported in #520 when The production change replaces two lines with existing helpers. The regression checks credential calls and Authorization headers with signing enabled and disabled. The public API is unchanged. The other PRs can remain drafts while this one receives review. Codex used. |
alamb
added
the
Prolific Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #760. This PR covers external-provider integration tests.
Rationale for this change
Existing provider tests do not show that an external implementation works through the public object_store client API.
What changes are included in this PR?
Add a separate downstream test crate with an external Ring provider and an in-memory HTTP connector.
Capture a signed PUT through the public AWS client and compare its signature with independent Ring operations.
Check digest and HMAC failure propagation, custom-provider selection, bundled-provider fallback, and
aws-basewithout a provider.Add CI commands for the separate crate. The fixture makes no cloud requests.
Validation on Ubuntu 24.04 with Rust 1.97.0:
The first job passed tests and Clippy but failed spelling with typos 1.37.0 on four unchanged identifiers.
The continuation passed formatting, typos 1.51.1, and source/lock integrity.
Its additional dependency audit failed because Cargo's CLI feature resolution adds nine TLS packages outside the persisted workspace lock.
Their recorded versions match the first job's compilation log. Both job failures remain visible.
Are there any user-facing changes?
No public API changes.
Codex used.