Repository navigation
fix: honor GCS skip_signature during uploads - #861
RanaPriyansh wants to merge 2 commits into
Conversation
|
Marking as draft per #873 (comment) so i can find the PRs that need attention. Thank you |
|
Reviewing this one per #873 |
|
@andrewhamon and @kylebarron -- any chance you are up for helping to review this PR? |
|
The test uses an explicit concrete Formatting passed on the source committed as The prior emulator job failed while pulling the MinIO image, before its tests. Codex used. |
|
I've never used GCS nor anonymous auth on GCS, so I don't have a way to validate this PR myself |
|
The public-API regression passed locally on The test uploads through cargo test --features gcp --lib gcp::test::gcs_skip_signature_skips_credentials_and_authorization -- --exact --nocaptureHosted Clippy also passed for this revision, including all targets. Live GCS anonymous uploads and bucket permissions remain untested. Codex used. |
Which issue does this PR close?
with_skip_signature(true)still attempting to fetch credentials #520.Rationale for this change
GCS upload requests fetched credentials and added a Bearer header even when
with_skip_signature(true)was set.Request::sendbypassed the existing skip-aware credential helper.What changes are included in this PR?
Route upload requests through
GoogleCloudStorageConfig::get_credential()and the optional Bearer-auth helper. Add a mock-server regression that checks credential calls and Authorization headers with signing enabled and disabled.Are there any user-facing changes?
GCS uploads with
skip_signature=trueno longer fetch credentials at request time or send an Authorization header. The public API is unchanged.Validation:
cargo test --features=aws,azure,gcp,httppassed: 264 unit tests, 3 integration tests, 1 HTTP test, and 57 doctests. Six unit tests and two doctests were ignored.--features gcpand--no-default-features --features gcp-base. Formatting and diff checks passed.cargo test --features gcphad one unrelated doctest failure: a doctest imports Azure when the Azure feature is disabled. The doctest passed with the repository CI feature set above.Live GCS and custom-connector behavior were not tested. Builder-time credential-file parsing is unchanged.
Codex used.