Repository navigation
fix: honor fsync for local deletes - #866
Draft
RanaPriyansh wants to merge 1 commit into
Draft
RanaPriyansh wants to merge 1 commit into
RanaPriyansh wants to merge 1 commit into
Conversation
alamb
marked this pull request as draft
October 16, 2026 21:21
Contributor
|
Marking as draft per #873 (comment) so i can find the PRs that need attention. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standalone deletes ignore
LocalFileSystem::with_fsync(true).Pass the configured flag to the deletion helper so direct and streamed deletes sync the parent directory after unlink. Retain the directory handle before unlink to prevent concurrent cleanup from removing the path before sync. Document that automatic directory cleanup is not synced.
Unix regression tests reproduce the missing sync-error propagation on the baseline. Controls cover concurrent deletion with cleanup, disabled fsync, symlink targets, and nested-directory cleanup. Permission tests skip when the host can open a directory without read permission.
Validation:
cargo test,cargo fmt --all -- --check,cargo clippy --all-features --all-targets -- -D warnings,cargo check --all-targets --all-features, and the CI Clippy feature matrix passed locally. No power-failure or Windows durability claim is made.Codex used.