Skip to content

fix(app): respect custom opencode project icons - #28855

Closed
angristan wants to merge 1 commit into
anomalyco:devfrom
angristan:fix-project-avatar-override
Closed

fix(app): respect custom opencode project icons#28855
angristan wants to merge 1 commit into
anomalyco:devfrom
angristan:fix-project-avatar-override

Conversation

@angristan

@angristan angristan commented May 22, 2026

Copy link
Copy Markdown
Contributor

Issue for this PR

Fixes #27882
Fixes #26888
Fixes #24744
Fixes #24197

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

The opencode project has a default hard-coded favicon. That default was returned before checking user-provided icon overrides, so an uploaded project icon could be saved but still not display for that project.

This changes the avatar-source precedence to prefer uploaded overrides first, then color avatars, then the opencode favicon fallback. It also adds regression coverage for that precedence.

How did you verify your code works?

Verification
  • bun test src/pages/layout/helpers.test.ts
  • bun typecheck

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@angristan
angristan requested a review from adamdotdevin as a code owner May 22, 2026 15:32
@github-actions github-actions Bot added needs:compliance This means the issue will auto-close after 2 hours. needs:issue contributor labels May 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions github-actions Bot removed needs:compliance This means the issue will auto-close after 2 hours. needs:issue labels May 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for updating your PR! It now meets our contributing guidelines. 👍

@github-actions

Copy link
Copy Markdown
Contributor

Automated PR Cleanup

Thank you for contributing to opencode.

Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions.

This PR was closed because it matched the following cleanup criteria:

  • The PR was created more than 1 month ago
  • The PR had fewer than 2 positive reactions
  • Positive reactions are counted as thumbs-up, heart, celebration, or rocket reactions on the PR

PRs created within the last month are not affected by this cleanup.

If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate.

Thanks again for taking the time to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

1 participant