fix(app): respect custom opencode project icons - #28855
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Fixes #27882
Fixes #26888
Fixes #24744
Fixes #24197
Type of change
What does this PR do?
The opencode project has a default hard-coded favicon. That default was returned before checking user-provided icon overrides, so an uploaded project icon could be saved but still not display for that project.
This changes the avatar-source precedence to prefer uploaded overrides first, then color avatars, then the opencode favicon fallback. It also adds regression coverage for that precedence.
How did you verify your code works?
Verification
bun test src/pages/layout/helpers.test.tsbun typecheckChecklist