Skip to content

fix: project edit dialog does not persist name and icon changes for local projects - #33494

Closed
Leto117 wants to merge 1 commit into
anomalyco:devfrom
Leto117:fix/project-name-persistence
Closed

fix: project edit dialog does not persist name and icon changes for local projects#33494
Leto117 wants to merge 1 commit into
anomalyco:devfrom
Leto117:fix/project-name-persistence

Conversation

@Leto117

@Leto117 Leto117 commented Jun 23, 2026

Copy link
Copy Markdown

Description

Fixes #32164

When editing a project's name or icon via the Edit dialog (right-click ? Edit) in the Desktop app for local projects (without a SQLite project ID), the name and icon are saved to the per-workspace persisted store via serverSync().project.meta(), but the enrich() function in global.tsx never reads them back.

Two issues in enrich():

  1. Name: childStore.projectMeta?.name was never checked - only childStore.icon was applied
  2. Icon: For local projects, icon is saved via projectMeta() into childStore.projectMeta.icon.override, but enrich() only checked the legacy childStore.icon field (written by projectIcon(), which is only called for server projects)

Changes

  • packages/app/src/context/global.tsx:
    • Added check for childStore.projectMeta?.name to apply local project name overrides
    • Added check for childStore.projectMeta?.icon?.override to apply local project icon overrides (with fallback to legacy childStore.icon)

@github-actions github-actions Bot added the needs:compliance This means the issue will auto-close after 2 hours. label Jun 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

Potential Duplicate Found:

PR #31736: fix: persist project edits for global/no-ID projects
#31736

This PR appears to be directly related to the current PR #33494. Both are addressing the issue of persisting project edits (specifically name changes) for projects without a SQLite ID (local/global projects). The current PR (#33494) likely represents a more recent or focused fix for the same underlying issue (#32164).

@Leto117
Leto117 force-pushed the fix/project-name-persistence branch from 6fcf2ac to e9fddee Compare June 23, 2026 10:31
@Leto117 Leto117 changed the title fix: project edit dialog does not persist name changes for local projects fix: project edit dialog does not persist name and icon changes for local projects Jun 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new pull request that follows our guidelines.

@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Jun 23, 2026
@github-actions github-actions Bot closed this Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Project edit dialog does not persist name or icon changes (Windows Desktop v1.17.4)

1 participant