Skip to content

Add margin support to Site Tagline - #31809

Merged
carolinan merged 1 commit into
WordPress:trunkfrom
stacimc:add/margin-support-to-site-tagline
May 17, 2021
Merged

carolinan merged 1 commit into
WordPress:trunkfrom
stacimc:add/margin-support-to-site-tagline

Conversation

@stacimc

@stacimc stacimc commented May 13, 2021

Copy link
Copy Markdown
Contributor

Description

Part of #30921
Depends on #31808
Adds the margin block support to the Site Tagline block.

How has this been tested?

Manually.

  1. Using a blocks theme such as Twenty Twenty-One Blocks, update the theme.json to enable margin support under the defaults or the core/site-title context:
                "spacing": {
			"customPadding": true,
			"customMargin": true,
			"units": [
				"px",
				"em",
				"rem",
				"vh",
				"vw"
			]
		},
  1. Open the site editor, and select the Site Tagline block.
  2. Open the Settings sidebar and expand the spacing settings panel in the inspector controls sidebar.
  3. Verify that the controls for both Padding and Margin are present.
  4. Modify the block's margins and verify that it looks as expected.
  5. Save the post and view on the frontend, confirming the Site Tagline displays correctly. This depends on Spacing support: Add server-side support for margins #31808.

Screenshots

Screen Capture on 2021-05-13 at 16-25-36

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • I've tested my changes with keyboard and screen readers.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR (please manually search all *.native.js files for terms that need renaming or removal).

@stacimc
stacimc requested a review from ajitbohra as a code owner May 13, 2021 23:26

@carolinan carolinan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me.

@priethor priethor added the [Block] Site Tagline Affects the Site Tagline Block label May 14, 2021
@apeatling
apeatling self-requested a review May 14, 2021 21:02

@apeatling apeatling left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@carolinan
carolinan merged commit 431adc1 into WordPress:trunk May 17, 2021
@github-actions github-actions Bot added this to the Gutenberg 10.7 milestone May 17, 2021
@carolinan carolinan mentioned this pull request May 17, 2021
7 of 9 tasks
@stacimc
stacimc deleted the add/margin-support-to-site-tagline branch May 17, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Site Tagline Affects the Site Tagline Block

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants