GH#977: remove error-reporting opt-in from settings page#980
Conversation
The global 'Help Improve Ultimate Multisite' toggle (enable_error_reporting) is replaced by per-send consent — users will be prompted when they explicitly send feedback, eliminating the need for an always-on opt-in. Changes: - Remove enable_error_reporting field from Settings::default_sections() - Remove enable_error_reporting from Settings::get_setting_defaults() - Remove the error-reporting table row from widget-settings-body.php - Tracker::is_tracking_enabled() now always returns false (no opt-in) - Remove wu_settings_update / wu_weekly / wu_log_add hooks from Tracker::init() - Tracker::maybe_send_initial_data() is now a no-op (method kept for back-compat) - Remove enable_error_reporting from Migrator keys_to_migrate list - Update Tracker_Test to match new no-op/always-false behaviour The crash support link (build_support_url / customize_fatal_error_message) is unaffected — it builds a URL the admin must click, requiring no opt-in. Refs #977
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 56 minutes and 32 seconds.Comment |
🔨 Build Complete - Ready for Testing!📦 Download Build Artifact (Recommended)Download the zip build, upload to WordPress and test:
🌐 Test in WordPress Playground (Very Experimental)Click the link below to instantly test this PR in your browser - no installation needed! Login credentials: |
|
Performance Test Results Performance test results for edc66b1 are in 🛎️! Note: the numbers in parentheses show the difference to the previous (baseline) test run. Differences below 2% or 0.5 in absolute values are not shown. URL:
|
SummaryRemoves the global Help Improve Ultimate Multisite opt-in toggle ( What changed
What is preservedThe crash support link feature ( TestingWP_TESTS_DIR=/tmp/wordpress-tests-lib vendor/bin/phpunit --filter Tracker_Test
# OK (48 tests, 101 assertions)
vendor/bin/phpstan analyse inc/class-tracker.php inc/class-settings.php
# No errorsaidevops.sh v3.13.10 plugin for OpenCode v1.3.17 with claude-sonnet-4-6 spent 9m and 28,073 tokens on this as a headless worker. Merged via PR #980 to main. |
…#1052) Add two entries to the 'does not exist' path table: - inc/managers/class-tracker-manager.php and inc/telemetry/class-tracker.php: points to correct location inc/class-tracker.php; notes that the enable_error_reporting opt-in was removed in 2.5.1 and is_tracking_enabled() always returns false - inc/managers/class-newsletter-manager.php and inc/newsletter/class-newsletter.php: points to correct location inc/class-newsletter.php These classes live at the inc/ root (like class-orphaned-tables-manager.php documented previously), not in subdirectories like most managers. Insight source: contributor superdav42 sessions mentioning feedback/telemetry settings (the opt-in removal was done in PR #980) and newsletter opt-in. Resolves #1048
Summary
Removes the global Help Improve Ultimate Multisite opt-in toggle (
enable_error_reporting) from the Settings page. Per the contributor insight fromsuperdav42(issue #977), consent should be obtained per-feedback-send rather than as a persistent global setting, and no API key is needed since the endpoint is fixed.What changed
inc/class-settings.phpenable_error_reportingfield fromdefault_sections()andget_setting_defaults()views/settings/widget-settings-body.phpinc/class-tracker.phpis_tracking_enabled()always returnsfalse; removedwu_settings_update/wu_weekly/wu_log_addhooks frominit();maybe_send_initial_data()is now a no-op (kept for back-compat)inc/installers/class-migrator.phpenable_error_reportingfrom the v1->v2 migration key listtests/WP_Ultimo/Tracker_Test.phpWhat is preserved
The crash support link feature (
Tracker::customize_fatal_error_message/build_support_url) is unchanged — it builds a pre-filled support URL that a super admin must click to send data, so it requires no opt-in.Testing
Resolves #977
aidevops.sh v3.13.10 plugin for OpenCode v1.3.17 with claude-sonnet-4-6 spent 9m and 28,073 tokens on this as a headless worker.