Skip to content

GH#977: remove error-reporting opt-in from settings page#980

Merged
superdav42 merged 1 commit into
mainfrom
feature/auto-20260429-011512-gh977
Apr 29, 2026
Merged

GH#977: remove error-reporting opt-in from settings page#980
superdav42 merged 1 commit into
mainfrom
feature/auto-20260429-011512-gh977

Conversation

@superdav42

Copy link
Copy Markdown
Collaborator

Summary

Removes the global Help Improve Ultimate Multisite opt-in toggle (enable_error_reporting) from the Settings page. Per the contributor insight from superdav42 (issue #977), consent should be obtained per-feedback-send rather than as a persistent global setting, and no API key is needed since the endpoint is fixed.

What changed

File Change
inc/class-settings.php Removed enable_error_reporting field from default_sections() and get_setting_defaults()
views/settings/widget-settings-body.php Removed the "Error Reporting" section and checkbox row
inc/class-tracker.php is_tracking_enabled() always returns false; removed wu_settings_update / wu_weekly / wu_log_add hooks from init(); maybe_send_initial_data() is now a no-op (kept for back-compat)
inc/installers/class-migrator.php Removed enable_error_reporting from the v1->v2 migration key list
tests/WP_Ultimo/Tracker_Test.php Updated tests to assert the new always-false / no-op behaviour

What is preserved

The crash support link feature (Tracker::customize_fatal_error_message / build_support_url) is unchanged — it builds a pre-filled support URL that a super admin must click to send data, so it requires no opt-in.

Testing

WP_TESTS_DIR=/tmp/wordpress-tests-lib vendor/bin/phpunit --filter Tracker_Test
# OK (48 tests, 101 assertions)
vendor/bin/phpstan analyse inc/class-tracker.php inc/class-settings.php
# No errors

Resolves #977


aidevops.sh v3.13.10 plugin for OpenCode v1.3.17 with claude-sonnet-4-6 spent 9m and 28,073 tokens on this as a headless worker.

The global 'Help Improve Ultimate Multisite' toggle (enable_error_reporting)
is replaced by per-send consent — users will be prompted when they
explicitly send feedback, eliminating the need for an always-on opt-in.

Changes:
- Remove enable_error_reporting field from Settings::default_sections()
- Remove enable_error_reporting from Settings::get_setting_defaults()
- Remove the error-reporting table row from widget-settings-body.php
- Tracker::is_tracking_enabled() now always returns false (no opt-in)
- Remove wu_settings_update / wu_weekly / wu_log_add hooks from Tracker::init()
- Tracker::maybe_send_initial_data() is now a no-op (method kept for back-compat)
- Remove enable_error_reporting from Migrator keys_to_migrate list
- Update Tracker_Test to match new no-op/always-false behaviour

The crash support link (build_support_url / customize_fatal_error_message)
is unaffected — it builds a URL the admin must click, requiring no opt-in.

Refs #977
@superdav42 superdav42 added the origin:worker Auto-created by pulse labelless backfill (t2112) label Apr 29, 2026
@coderabbitai

coderabbitai Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@superdav42 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 56 minutes and 32 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 28a29535-fc7d-4b7d-bdb4-72f5158afc5d

📥 Commits

Reviewing files that changed from the base of the PR and between da4e600 and 706b77b.

📒 Files selected for processing (5)
  • inc/class-settings.php
  • inc/class-tracker.php
  • inc/installers/class-migrator.php
  • tests/WP_Ultimo/Tracker_Test.php
  • views/settings/widget-settings-body.php
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/auto-20260429-011512-gh977

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 56 minutes and 32 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

@github-actions

Copy link
Copy Markdown

Performance Test Results

Performance test results for edc66b1 are in 🛎️!

Note: the numbers in parentheses show the difference to the previous (baseline) test run. Differences below 2% or 0.5 in absolute values are not shown.

URL: /

Run DB Queries Memory Before Template Template WP Total LCP TTFB LCP - TTFB
0 40 (-1 / -3% ) 37.78 MB 885.50 ms (-25.50 ms / -3% ) 182.50 ms (+22.00 ms / +12% ) 1094.00 ms (-44.50 ms / -4% ) 2104.00 ms (-48.00 ms / -2% ) 2024.20 ms 89.20 ms
1 56 49.03 MB 963.00 ms 151.00 ms 1114.00 ms 2122.00 ms 2040.10 ms 80.50 ms

@superdav42 superdav42 merged commit be668b1 into main Apr 29, 2026
11 checks passed
@superdav42

Copy link
Copy Markdown
Collaborator Author

Summary

Removes the global Help Improve Ultimate Multisite opt-in toggle (enable_error_reporting) from the Settings page. Per the contributor insight from superdav42 (issue #977), consent should be obtained per-feedback-send rather than as a persistent global setting, and no API key is needed since the endpoint is fixed.

What changed

File Change
inc/class-settings.php Removed enable_error_reporting field from default_sections() and get_setting_defaults()
views/settings/widget-settings-body.php Removed the "Error Reporting" section and checkbox row
inc/class-tracker.php is_tracking_enabled() always returns false; removed wu_settings_update / wu_weekly / wu_log_add hooks from init(); maybe_send_initial_data() is now a no-op (kept for back-compat)
inc/installers/class-migrator.php Removed enable_error_reporting from the v1->v2 migration key list
tests/WP_Ultimo/Tracker_Test.php Updated tests to assert the new always-false / no-op behaviour

What is preserved

The crash support link feature (Tracker::customize_fatal_error_message / build_support_url) is unchanged — it builds a pre-filled support URL that a super admin must click to send data, so it requires no opt-in.

Testing

WP_TESTS_DIR=/tmp/wordpress-tests-lib vendor/bin/phpunit --filter Tracker_Test
# OK (48 tests, 101 assertions)
vendor/bin/phpstan analyse inc/class-tracker.php inc/class-settings.php
# No errors

aidevops.sh v3.13.10 plugin for OpenCode v1.3.17 with claude-sonnet-4-6 spent 9m and 28,073 tokens on this as a headless worker.


Merged via PR #980 to main.
Merged by deterministic merge pass (pulse-wrapper.sh).

superdav42 added a commit that referenced this pull request Apr 30, 2026
…#1052)

Add two entries to the 'does not exist' path table:
- inc/managers/class-tracker-manager.php and inc/telemetry/class-tracker.php:
  points to correct location inc/class-tracker.php; notes that the
  enable_error_reporting opt-in was removed in 2.5.1 and
  is_tracking_enabled() always returns false
- inc/managers/class-newsletter-manager.php and inc/newsletter/class-newsletter.php:
  points to correct location inc/class-newsletter.php

These classes live at the inc/ root (like class-orphaned-tables-manager.php
documented previously), not in subdirectories like most managers.

Insight source: contributor superdav42 sessions mentioning feedback/telemetry
settings (the opt-in removal was done in PR #980) and newsletter opt-in.

Resolves #1048
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

origin:worker Auto-created by pulse labelless backfill (t2112)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Contributor insight: 6 instruction candidate(s) from superdav42

1 participant