Skip to content

GH#977: remove error-reporting opt-in from settings page #980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
superdav42 merged 1 commit into from
Apr 29, 2026
Merged

GH#977: remove error-reporting opt-in from settings page #980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions inc/class-settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -734,22 +734,6 @@ public function default_sections(): void {
120
);

$this->add_field(
'general',
'enable_error_reporting',
[
'title' => __('Help Improve Ultimate Multisite', 'ultimate-multisite'),
'desc' => sprintf(
/* translators: %s is a link to the privacy policy */
__('Allow Ultimate Multisite to collect anonymous usage data and error reports to help us improve the plugin. We collect: PHP version, WordPress version, plugin version, network type (subdomain/subdirectory), aggregate counts (sites, memberships), active gateways, and error logs. We never collect personal data, customer information, or domain names. <a href="%s" target="_blank" rel="noopener noreferrer">Learn more</a>.', 'ultimate-multisite'),
esc_url('https://ultimatemultisite.com/privacy-policy/')
),
'type' => 'toggle',
'default' => 0,
],
130
);

$this->add_field(
'general',
'enable_beta_updates',
Expand Down Expand Up @@ -2013,7 +1997,6 @@ public static function get_setting_defaults(): array {
'decimal_separator' => '.',
'thousand_separator' => ',',
'precision' => '2',
'enable_error_reporting' => 0,
'enable_beta_updates' => 0,

// Login & Registration
Expand Down
52 changes: 22 additions & 30 deletions inc/class-tracker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@
/**
* Tracker class for anonymous usage data collection.
*
* Background telemetry (opt-in toggle) was removed in 2.5.1 — consent is now
* obtained per-feedback-send rather than as a global setting. The crash support
* link feature (build_support_url / customize_fatal_error_message) remains and
* requires no opt-in since the admin must click the link to send data.
*
* @since 2.5.0
*/
class Tracker implements \WP_Ultimo\Interfaces\Singleton {
Expand Down Expand Up @@ -66,20 +71,9 @@ class Tracker implements \WP_Ultimo\Interfaces\Singleton {
*/
public function init(): void {

// Create the weekly schedule
add_action('init', [$this, 'create_weekly_schedule']);

// Hook into weekly cron for usage data
add_action('wu_weekly', [$this, 'maybe_send_tracking_data']);

// Hook into Logger for error reporting (now receives log level as 3rd param)
add_action('wu_log_add', [$this, 'maybe_send_error'], 10, 3);

// Customize fatal error message for network sites
// Customize fatal error message for network sites (no opt-in required —
// the admin must click the support link to send any data).
add_filter('wp_php_error_message', [$this, 'customize_fatal_error_message'], 10, 2);

// Send initial data when tracking is first enabled
add_action('wu_settings_update', [$this, 'maybe_send_initial_data'], 10, 2);
}

/**
Expand All @@ -98,19 +92,27 @@ public function create_weekly_schedule(): void {
}

/**
* Check if tracking is enabled.
* Check if background telemetry is enabled.
*
* Background telemetry (the opt-in toggle) was removed in 2.5.1.
* Consent is now obtained per-feedback-send rather than as a global
* setting, so this method always returns false. It is kept for
* backwards-compatibility with add-ons that may call it directly.
*
* @since 2.5.0
* @return bool
*/
public function is_tracking_enabled(): bool {

return (bool) wu_get_setting('enable_error_reporting', false);
return false;
}

/**
* Send tracking data if enabled and due.
*
* Background telemetry was removed in 2.5.1 (opt-in toggle replaced by
* per-send consent). This method is a no-op and will always return early.
*
* @since 2.5.0
* @return void
*/
Expand All @@ -130,7 +132,10 @@ public function maybe_send_tracking_data(): void {
}

/**
* Send initial data when tracking is first enabled.
* No-op: sending initial data on settings-toggle was removed in 2.5.1.
*
* The wu_settings_update hook for this method was also removed in init().
* The method signature is preserved so callers are not fatally broken.
*
* @since 2.5.0
* @param string $setting_id The setting being updated.
Expand All @@ -139,20 +144,7 @@ public function maybe_send_tracking_data(): void {
*/
public function maybe_send_initial_data(string $setting_id, $value): void {

if ('enable_error_reporting' !== $setting_id) {
return;
}

if ( ! $value) {
return;
}

// Check if we've never sent data before
$last_send = get_site_option(self::LAST_SEND_OPTION, 0);

if (0 === $last_send) {
$this->send_tracking_data();
}
// No-op: background telemetry opt-in was removed in 2.5.1.
}

/**
Expand Down
1 change: 0 additions & 1 deletion inc/installers/class-migrator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -782,7 +782,6 @@ protected function _install_settings() {
'domain_options',

// Dev Options
'enable_error_reporting',
'uninstall_wipe_tables',

// Registration
Expand Down
22 changes: 7 additions & 15 deletions tests/WP_Ultimo/Tracker_Test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,13 @@ public function test_get_instance(): void {
}

/**
* Test is_tracking_enabled returns bool.
* Test is_tracking_enabled always returns false (background telemetry removed in 2.5.1).
*/
public function test_is_tracking_enabled(): void {

$result = $this->get_tracker()->is_tracking_enabled();

$this->assertIsBool($result);
$this->assertFalse($result);
}

/**
Expand Down Expand Up @@ -587,21 +587,13 @@ public function test_prepare_error_data(): void {
}

/**
* Test maybe_send_initial_data does nothing for wrong setting.
* Test maybe_send_initial_data is a no-op (background telemetry removed in 2.5.1).
*/
public function test_maybe_send_initial_data_wrong_setting(): void {
public function test_maybe_send_initial_data_is_noop(): void {

$this->get_tracker()->maybe_send_initial_data('other_setting', true);

$this->assertTrue(true);
}

/**
* Test maybe_send_initial_data does nothing when value is false.
*/
public function test_maybe_send_initial_data_false_value(): void {

$this->get_tracker()->maybe_send_initial_data('enable_error_reporting', false);
// Both calls must complete without errors — the method is now a no-op.
$this->get_tracker()->maybe_send_initial_data('any_setting', true);
$this->get_tracker()->maybe_send_initial_data('any_setting', false);

$this->assertTrue(true);
}
Expand Down
32 changes: 0 additions & 32 deletions views/settings/widget-settings-body.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,38 +263,6 @@ class="wu-bg-gray-100 wu--mt-1 wu--mx-3 wu-p-4 wu-border-solid wu-border-b wu-bo
</tbody>
</table>

<div id="error_reporting" data-type="heading">
<h3>Error Reporting</h3>
<p>Help us make Ultimate Multisite better by automatically reporting fatal errors and warnings so we can fix them as
soon
as possible.</p>
</div>

<table class="form-table">
<tbody>


<tr>
<th scope="row"><label for="enable_error_reporting"><?php esc_html_e('Help Improve Ultimate Multisite', 'ultimate-multisite'); ?></label></th>
<td>

<label for="enable_error_reporting">
<input name="enable_error_reporting" type="checkbox" id="enable_error_reporting" value="1">
<?php esc_html_e('Help Improve Ultimate Multisite', 'ultimate-multisite'); ?>
</label>

<p class="description" id="enable_error_reporting-desc">
<?php esc_html_e('Allow Ultimate Multisite to collect anonymous usage data and error reports to help us improve the plugin. We collect: PHP version, WordPress version, plugin version, network type, aggregate counts, active gateways, and error logs. We never collect personal data, customer information, or domain names.', 'ultimate-multisite'); ?>
<a href="https://ultimatemultisite.com/privacy-policy/" target="_blank"><?php esc_html_e('Learn more', 'ultimate-multisite'); ?></a>.
</p>

</td>
</tr>


</tbody>
</table>

<div id="uninstall" data-type="heading">
<h3>Uninstall Options</h3>
<p>Change the plugin behavior on uninstall.</p>
Expand Down
Loading