GH#1048: fix AGENTS.md — tracker and newsletter singleton paths from contributor insight review by superdav42 · Pull Request #1052 · Ultimate-Multisite/ultimate-multisite

superdav42 · 2026-04-30T22:06:51Z

Summary

Contributor insight review for issue #1048 (7 instruction candidates from superdav42).

Triage outcome:

Item WP Multisite WaaS 2.3.3 #6 (remove Feedback Reports from settings): already implemented in PR GH#977: remove error-reporting opt-in from settings page #980 — enable_error_reporting opt-in removed, is_tracking_enabled() always returns false
Item WP Multisite WaaS 2.3.3-beta2 #4 (production bugs): Bug Welcome to WP Multisite WaaS Discussions! #1 (orphan pending_site) fixed in GH#1037 / PR GH#1037: fix: clean up orphaned pending_site records when membership is missing #1041; bugs Domain Seller #2/User privacy #3 not visible (text truncated in auto-generated issue body)
Items Welcome to WP Multisite WaaS Discussions! #1, Domain Seller #2, User privacy #3, Domain Mapping Issue #5, Fatal Error #7: general questions or cross-repo content — not actionable for this repo

Changes:

Add two entries to the AGENTS.md 'does not exist' path table, following the same pattern as the class-orphaned-tables-manager.php entry added in PR #1047:

inc/managers/class-tracker-manager.php / inc/telemetry/class-tracker.php — agents looking for the telemetry singleton in a subdirectory; correct path is inc/class-tracker.php. Also notes the enable_error_reporting removal so agents don't search for that setting.
inc/managers/class-newsletter-manager.php / inc/newsletter/class-newsletter.php — agents looking for the newsletter opt-in in a subdirectory; correct path is inc/class-newsletter.php.

Both classes live at the inc/ root (like the orphaned-table/user managers documented in #1047).

Testing

No code changes — documentation only.

# Verify entries are correct
git ls-files 'inc/class-tracker.php' 'inc/class-newsletter.php'
# Should return both files

git ls-files 'inc/managers/class-tracker-manager.php' 'inc/telemetry/class-tracker.php'
# Should return empty (paths do not exist)

git ls-files 'inc/managers/class-newsletter-manager.php' 'inc/newsletter/class-newsletter.php'
# Should return empty (paths do not exist)

Resolves #1048

aidevops.sh v3.13.17 plugin for OpenCode v1.3.17 with claude-sonnet-4-6 spent 16m and 37,890 tokens on this as a headless worker.

Summary by CodeRabbit

Documentation
- Updated developer documentation to clarify system configuration and telemetry behavior. Confirms that telemetry tracking is always disabled and background opt-in was removed in version 2.5.1.

Add two entries to the 'does not exist' path table: - inc/managers/class-tracker-manager.php and inc/telemetry/class-tracker.php: points to correct location inc/class-tracker.php; notes that the enable_error_reporting opt-in was removed in 2.5.1 and is_tracking_enabled() always returns false - inc/managers/class-newsletter-manager.php and inc/newsletter/class-newsletter.php: points to correct location inc/class-newsletter.php These classes live at the inc/ root (like class-orphaned-tables-manager.php documented previously), not in subdirectories like most managers. Insight source: contributor superdav42 sessions mentioning feedback/telemetry settings (the opt-in removal was done in PR #980) and newsletter opt-in. Resolves #1048

superdav42 · 2026-04-30T22:07:13Z

Merge Summary

PR: #1052 — GH#1048: fix AGENTS.md — tracker and newsletter singleton paths from contributor insight review

What was done:
Contributor insight review for #1048 (7 instruction candidates from superdav42).

Triage of all 7 insights:

httpbl_access_key proxy question — general discussion, not actionable
IP blacklist services comparison — general discussion, not actionable
renderpeople.com 3D people — unrelated to this plugin
Production bugs (truncated): Bug Welcome to WP Multisite WaaS Discussions! #1 (orphan pending_site after gateway timeout) was fixed in GH#1037 / PR GH#1037: fix: clean up orphaned pending_site records when membership is missing #1041; bugs Domain Seller #2/User privacy #3 not visible in the truncated auto-generated body
WP 6.9 gratis-ai-agent connector page — cross-repo (different plugin), not actionable here
Feedback Reports removal — already implemented in PR GH#977: remove error-reporting opt-in from settings page #980; enable_error_reporting opt-in removed, Tracker::is_tracking_enabled() always returns false
Version v2.0.23 question — not actionable

AGENTS.md changes:
Added two path table entries following the pattern established in PR #1047:

inc/managers/class-tracker-manager.php / inc/telemetry/class-tracker.php → correct path is inc/class-tracker.php (also notes the enable_error_reporting setting removal)
inc/managers/class-newsletter-manager.php / inc/newsletter/class-newsletter.php → correct path is inc/class-newsletter.php

Verification: Documentation-only change; no code modified.

aidevops.sh v3.13.17 plugin for OpenCode v1.3.17 with claude-sonnet-4-6 spent 17m and 38,483 tokens on this as a headless worker.

coderabbitai · 2026-04-30T22:07:32Z

Warning

Rate limit exceeded

@superdav42 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 50 minutes and 21 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 240dddf3-defe-4bcc-9b49-e0ae3fa48e85

📥 Commits

Reviewing files that changed from the base of the PR and between 8651561 and f92649a.

📒 Files selected for processing (1)

AGENTS.md

📝 Walkthrough

Walkthrough

The PR updates AGENTS.md documentation by adding two new "does not exist" path mappings for telemetry/tracking and newsletter opt-in singletons under inc/. Behavioral notes document that background opt-in was removed in version 2.5.1 and tracking is always disabled.

Changes

Cohort / File(s)	Summary
AGENTS.md Documentation `AGENTS.md`	Added two new "does not exist" path mappings for `inc/`-based telemetry/tracking and newsletter opt-in singletons. Included behavioral documentation noting version 2.5.1 removal of background opt-in, permanent disabling of tracking via `is_tracking_enabled()`, and guidance to ignore `enable_error_reporting` settings.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

GH#988: docs: improve AGENTS.md guidance for 4 recurring contributor error patterns #989: Expands "does not exist" path mappings in AGENTS.md with similar inc/ path entries for telemetry and tracking-related documentation
docs: add AGENTS.md with build commands, code style, and project conventions #688: Directly builds on the AGENTS.md foundation introduced in this PR by editing the same file with path mapping updates
docs: strengthen AGENTS.md to reduce recurring agent error patterns (GH#948) #949: Modifies AGENTS.md's "do-not-exist" file list with additional inc/ path entries for non-existent singletons

Poem

🐰 A telemetry tale in markdown so fine,
Two paths now mapped under inc/'s design,
No tracking shall run, no opt-in shall hide,
The docs now shine clear with truthful guide! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title directly references issue GH#1048 and accurately describes the main change: fixing AGENTS.md with corrected singleton paths based on contributor review.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feature/auto-20260430-154942-gh1048

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Review rate limit: 0/1 reviews remaining, refill in 50 minutes and 21 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2026-04-30T22:09:37Z

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

Build: ultimate-multisite
⬇️ Download from GitHub Actions
⬇️ Download without Github Account (nightly.link)

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

github-actions · 2026-04-30T22:13:28Z

Performance Test Results

Performance test results for 22353f9 are in 🛎️!

Note: the numbers in parentheses show the difference to the previous (baseline) test run. Differences below 2% or 0.5 in absolute values are not shown.

URL: /

Run	DB Queries	Memory	Before Template	Template	WP Total	LCP	TTFB	LCP - TTFB
0	41	37.83 MB	937.00 ms (+55.50 ms / +6% )	154.50 ms	1113.00 ms (+40.50 ms / +4% )	2106.00 ms (+46.00 ms / +2% )	2020.35 ms	86.30 ms
1	56	49.10 MB	967.00 ms	142.50 ms	1110.50 ms	2156.00 ms	2072.70 ms	81.70 ms

github-actions · 2026-04-30T22:17:18Z

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

Build: ultimate-multisite
⬇️ Download from GitHub Actions
⬇️ Download without Github Account (nightly.link)

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

superdav42 added the origin:interactive Created by interactive user session label Apr 30, 2026

superdav42 mentioned this pull request Apr 30, 2026

[Supervisor:superdav42] 13 PRs, 0 assigned, 0 workers at 17:16 UTC #798

Open

Merge branch 'main' into feature/auto-20260430-154942-gh1048

f92649a

superdav42 merged commit 4f0fbac into main Apr 30, 2026
11 checks passed

superdav42 deleted the feature/auto-20260430-154942-gh1048 branch April 30, 2026 22:22

superdav42 mentioned this pull request Apr 30, 2026

Contributor insight: 7 instruction candidate(s) from superdav42 #1048

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

GH#1048: fix AGENTS.md — tracker and newsletter singleton paths from contributor insight review#1052

GH#1048: fix AGENTS.md — tracker and newsletter singleton paths from contributor insight review#1052
superdav42 merged 2 commits into
mainfrom
feature/auto-20260430-154942-gh1048

superdav42 commented Apr 30, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

superdav42 commented Apr 30, 2026

Uh oh!

coderabbitai Bot commented Apr 30, 2026 •

edited

Loading

Rate limit exceeded

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

github-actions Bot commented Apr 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

superdav42 commented Apr 30, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Summary by CodeRabbit

Uh oh!

superdav42 commented Apr 30, 2026

Merge Summary

Uh oh!

coderabbitai Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

Uh oh!

github-actions Bot commented Apr 30, 2026

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

🌐 Test in WordPress Playground (Very Experimental)

Uh oh!

github-actions Bot commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 30, 2026

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

🌐 Test in WordPress Playground (Very Experimental)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

superdav42 commented Apr 30, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 30, 2026 •

edited

Loading

github-actions Bot commented Apr 30, 2026 •

edited

Loading