Repository navigation
fix: a pull request snapshot without a file count shows none - #704
Merged
Merged
Conversation
Tryanks
marked this pull request as ready for review
October 11, 2026 07:30
Tryanks
enabled auto-merge (squash)
October 11, 2026 07:30
13 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A Bitbucket or Azure DevOps summary has no changed-file count, so the snapshot carried
changed_files: 0and the PR page's Files tab read "Files 0" until a files read answered. The count is now optional end to end, as #690 made additions and deletions.Readers of the snapshot's count: only the Files tab label (
detail.rs). The row detail inpull_requests/mod.rsshows the line stat, not the file count; the watch fingerprint (pull_request_watch.rs) does not include it; nothing sorts by it. Once the files read answers, the tab shows the read'sPullRequestFiles.changed_files, which the label already preferred; no new state.Evidence
Before: Bitbucket/Azure snapshot
changed_files: 0→ tab "Files 0" (reported in feat: Bitbucket Cloud pull requests #696 and feat: Azure DevOps pull requests #702).After: PR page on an Azure DevOps PR read anonymously (public
PowerShell/PSGallery-Cache-RepoFrosted Instrument: full visual redesign on macOS vibrancy #53, linked by discovery from a checkout on its branch; freshTCODE_DATA_DIR, throwaway HOME,HOSTNAME="Demo Mac", English, light). The tab reads "Files":Tests:
tcode-core pull_request::tests::a_kept_snapshot_reads_its_counts(wasa_kept_snapshot_reads_its_line_counts, extended): a literal snapshot kept before this change, withchanged_files: 2, still readsSome(2); one without the field readsNone. Before this change the type wasu64, so a missing field could not read as absent at all; withOption<u64>serde already reads a missing field asNone, so theserde(default)matches feat: GitLab merge requests as pull requests #690's form rather than being load-bearing.tcode-ui pull_requests::detail::tests::a_snapshot_without_a_file_count_labels_the_files_tab_without_one: a linked snapshot without a count labels the tab "Files"; once the files read answers (150), it reads "Files 150". gpui's test context cannot read rendered text, so the label moved from a closure inswitchintoPullRequestView::files_label, whichswitchrenders.Checks (macOS):
cargo fmt --all --check: cleancargo clippy --workspace --all-targets --locked -- -D warnings: Finished, no warningscargo nextest run --workspace --locked: 1156 tests run: 1156 passed, 13 skippedcargo machete: no unused dependenciesWindows/Linux, mobile and Web: CI. Phone and dark theme not attached (desktop light only for this fix).
Merge Danger
Door: two-way
Blast Radius: small
The wire's
changed_filesmay now be null. Client and host build from one tree between releases (Principle 9). A snapshot kept before this change still loads.Closes #698