Skip to content

Pull requests: the Files tab says "Files 0" before the first files read on hosts without a file count #698

Description

@Tryanks

Found in the #696 review (Bitbucket). A Bitbucket summary has no changed-file count, so crates/services/src/bitbucket/reads.rs fills changed_files: 0 and the PR page's Files tab reads "Files 0" until the first files read. PullRequestSnapshot.changed_files is not optional. Fix: make the count optional on the wire and in core (as #690 did for additions/deletions), hide the number when absent, GitHub/Forgejo/GitLab keep filling it. Owner: core pull_request snapshot, protocol, the Files tab label in crates/ui/src/pull_requests/detail.rs. Follow-up to #643 step 4.

Also Azure DevOps (#702): the summary has no file count either, so the Files tab reads "Files 0" anonymously until the first credentialed files read.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions